From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fDXUq-0003F9-Hi for qemu-devel@nongnu.org; Tue, 01 May 2018 11:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fDXUl-0001Ls-MA for qemu-devel@nongnu.org; Tue, 01 May 2018 11:47:16 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:39657) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fDXUl-0001L6-9M for qemu-devel@nongnu.org; Tue, 01 May 2018 11:47:11 -0400 Received: by mail-wm0-x22e.google.com with SMTP id f8so9110979wmc.4 for ; Tue, 01 May 2018 08:47:11 -0700 (PDT) References: <20180425012300.14698-1-richard.henderson@linaro.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <20180425012300.14698-1-richard.henderson@linaro.org> Date: Tue, 01 May 2018 16:47:08 +0100 Message-ID: <87d0yf9y4j.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org Richard Henderson writes: > When running the gcc testsuite with current aarch64-linux-user, > the testsuite detects the presence of the fp16 extension and > enables lots of extra tests for builtins. > > Quite a few of these new tests fail because we missed implementing > some instructions. We really should go back and verify that nothing > else is missing from this (rather large) extension. > > In addition, it tests some edge conditions on data that show flaws > in the way we were performing integer<->fp conversion; particularly > with respect to scaled conversion. I've finished reviewing this patch set. > PS: FWIW, this was written against my tgt-arm-sve-9 tree, since I > was trying to test sve as generated by gcc. I don't *think* there > are any dependencies on any of the sve patches, but I didn't check. They aren't. > > PPS: There are two more failures that might be qemu fp16 failures, > but those are SIGSEGV. This patch set cures all of the SIGILL and > (subsequent) SIGABRT type failures within the testsuite. I've also pushed the fix to sqrt_f16 (passing cpu_env rather than fpst). Are you happy rolling my fixes into your v2? > > > Richard Henderson (9): > target/arm: Implement vector shifted SCVF/UCVF for fp16 > target/arm: Implement vector shifted FCVT for fp16 > target/arm: Fix float16 to/from int16 > target/arm: Clear SVE high bits for FMOV > target/arm: Implement FMOV (general) for fp16 > target/arm: Implement FCVT (scalar,integer) for fp16 > target/arm: Implement FCVT (scalar,fixed-point) for fp16 > target/arm: Implement FP data-processing (2 source) for fp16 > target/arm: Implement FP data-processing (3 source) for fp16 > > target/arm/helper.h | 6 + > target/arm/helper.c | 87 ++++++++++- > target/arm/translate-a64.c | 371 +++++++++++++++++++++++++++++++++++++--= ------ > 3 files changed, 399 insertions(+), 65 deletions(-) -- Alex Benn=C3=A9e