From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: peter.maydell@linaro.org, laurent@vivier.eu,
bharata@linux.vnet.ibm.com, andrew@andrewdutcher.com,
aleksandar.markovic@imgtec.com, qemu-devel@nongnu.org,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper
Date: Tue, 19 Dec 2017 07:31:07 +0000 [thread overview]
Message-ID: <87d13b6uo4.fsf@linaro.org> (raw)
In-Reply-To: <c17e6c00-0a9f-054a-88c4-5868081daccf@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes:
> On 12/11/2017 04:56 AM, Alex Bennée wrote:
>> +static inline float16 float16_set_sign(float16 a, int sign)
>> +{
>> + return make_float16((float16_val(a) & 0x7fff) | (sign << 15));
>> +}
>> +
>
> 1) Do we use this anywhere?
Yes in the target specific helpers
>
> 2) While this is probably in line with the other implementations,
> but going to a more qemu-ish style this should use deposit32.
OK, will do.
>
> Anyway,
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
--
Alex Bennée
next prev parent reply other threads:[~2017-12-19 7:31 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 12:56 [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions Alex Bennée
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 01/19] fpu/softfloat: implement float16_squash_input_denormal Alex Bennée
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 02/19] include/fpu/softfloat: implement float16_abs helper Alex Bennée
2017-12-15 11:35 ` Philippe Mathieu-Daudé
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 03/19] include/fpu/softfloat: implement float16_chs helper Alex Bennée
2017-12-18 21:41 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 04/19] include/fpu/softfloat: implement float16_set_sign helper Alex Bennée
2017-12-18 21:44 ` Richard Henderson
2017-12-19 7:31 ` Alex Bennée [this message]
2018-01-08 12:58 ` Alex Bennée
2018-01-08 20:25 ` Richard Henderson
2018-01-05 16:15 ` Philippe Mathieu-Daudé
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 05/19] include/fpu/softfloat: add some float16 contants Alex Bennée
2017-12-15 12:24 ` Alex Bennée
2017-12-15 13:37 ` Philippe Mathieu-Daudé
2017-12-18 21:50 ` Richard Henderson
2018-01-04 14:09 ` Alex Bennée
2018-01-04 15:05 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 06/19] fpu/softfloat: propagate signalling NaNs in MINMAX Alex Bennée
2017-12-18 21:53 ` Richard Henderson
2018-01-05 13:05 ` Alex Bennée
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 07/19] fpu/softfloat: improve comments on ARM NaN propagation Alex Bennée
2017-12-18 21:54 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 08/19] fpu/softfloat: move the extract functions to the top of the file Alex Bennée
2017-12-18 21:57 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 09/19] fpu/softfloat: define decompose structures Alex Bennée
2017-12-18 21:59 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 10/19] fpu/softfloat: re-factor add/sub Alex Bennée
2017-12-18 22:18 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 11/19] fpu/softfloat: re-factor mul Alex Bennée
2017-12-18 22:22 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 12/19] fpu/softfloat: re-factor div Alex Bennée
2017-12-18 22:26 ` Richard Henderson
2017-12-11 12:56 ` [Qemu-devel] [PATCH v1 13/19] fpu/softfloat: re-factor muladd Alex Bennée
2017-12-18 22:36 ` Richard Henderson
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 14/19] fpu/softfloat: re-factor round_to_int Alex Bennée
2017-12-18 22:41 ` Richard Henderson
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 15/19] fpu/softfloat: re-factor float to int/uint Alex Bennée
2017-12-18 22:54 ` Richard Henderson
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 16/19] fpu/softfloat: re-factor int/uint to float Alex Bennée
2017-12-12 17:21 ` Alex Bennée
2017-12-18 22:59 ` Richard Henderson
2018-01-05 15:51 ` Alex Bennée
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 17/19] fpu/softfloat: re-factor scalbn Alex Bennée
2017-12-18 23:00 ` Richard Henderson
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 18/19] fpu/softfloat: re-factor minmax Alex Bennée
2017-12-18 23:19 ` Richard Henderson
2017-12-11 12:57 ` [Qemu-devel] [PATCH v1 19/19] fpu/softfloat: re-factor compare Alex Bennée
2017-12-18 23:26 ` Richard Henderson
2017-12-11 13:42 ` [Qemu-devel] [PATCH v1 00/19] re-factor softfloat and add fp16 functions no-reply
2017-12-11 15:40 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d13b6uo4.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.markovic@imgtec.com \
--cc=andrew@andrewdutcher.com \
--cc=aurelien@aurel32.net \
--cc=bharata@linux.vnet.ibm.com \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).