From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl
Date: Fri, 06 Oct 2017 18:13:38 +0200 [thread overview]
Message-ID: <87d1601cgd.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <874lrc92u1.fsf@dusky.pond.sub.org> (Markus Armbruster's message of "Fri, 06 Oct 2017 09:01:58 +0200")
Markus Armbruster <armbru@redhat.com> writes:
> "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:
>
>> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>>
>> opt was declared as a separate local inside the last loop,
>> shadowing the local at the top of the function.
>>
>> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
>
> I can take this through my tree.
I'd like to change the headline to "option: Remove shadowing opt decl
from qemu_opt_print()", if that's alright with you.
next prev parent reply other threads:[~2017-10-06 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 19:07 [Qemu-devel] [PATCH] qemu_opt_print: Remove shadowing opt decl Dr. David Alan Gilbert (git)
2017-10-05 19:12 ` Eric Blake
2017-10-06 7:01 ` Markus Armbruster
2017-10-06 16:13 ` Markus Armbruster [this message]
2017-10-06 16:20 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1601cgd.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).