From: Markus Armbruster <armbru@redhat.com>
To: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
Mohammed Gamal <mohammed.gamal@profitbricks.com>,
Eduardo Habkost <ehabkost@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-devel@nongnu.org,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Eduardo Otubo <eduardo.otubo@profitbricks.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command
Date: Wed, 16 Aug 2017 08:01:11 +0200 [thread overview]
Message-ID: <87d17wf3vc.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <CAPHE7Nrr9Y-F37PWS=rTS5hak09-_3v_R-T7KG+zQuy2L8U0jg@mail.gmail.com> (Vadim Galitsyn's message of "Tue, 15 Aug 2017 17:43:00 +0200")
Vadim Galitsyn <vadim.galitsyn@profitbricks.com> writes:
> Hi Guys,
>
> Thank you for the input!
>
>> "hotunpluggable" is ugly. What about just "pluggable"?
>
> Markus, I think "pluggable" is a bit misleading here. Some people can take
> it like a maximum amount of memory that can be hot-added to a guest (i.e.,
> difference between static memory size and value specified with "-m
> ...,maxmem=XXX"). I would say:
>
> mem_info->plugged_memory = get_plugged_memory_size();
>
> ..since it reflects actual amount which was already hot-added. Agree?
I like it. Thanks!
[...]
next prev parent reply other threads:[~2017-08-16 6:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 12:10 [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands Vadim Galitsyn
2017-07-28 12:10 ` [Qemu-devel] [PATCH v5 1/3] Extend "info numa" with hotplugged memory information Vadim Galitsyn
2017-07-28 12:10 ` [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command Vadim Galitsyn
2017-07-28 18:25 ` Eric Blake
2017-08-14 14:23 ` Markus Armbruster
2017-08-15 7:51 ` Igor Mammedov
2017-08-15 15:43 ` Vadim Galitsyn
2017-08-15 16:11 ` Igor Mammedov
2017-08-16 6:01 ` Markus Armbruster [this message]
2017-08-16 11:10 ` Vadim Galitsyn
2017-07-28 12:10 ` [Qemu-devel] [PATCH v5 3/3] hmp: introduce 'info memory-size-summary' command Vadim Galitsyn
2017-07-28 18:27 ` Eric Blake
2017-08-15 15:47 ` Vadim Galitsyn
2017-08-14 14:25 ` Markus Armbruster
2017-08-14 14:32 ` [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands Markus Armbruster
2017-08-15 7:54 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d17wf3vc.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eduardo.otubo@profitbricks.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=mohammed.gamal@profitbricks.com \
--cc=qemu-devel@nongnu.org \
--cc=vadim.galitsyn@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).