From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown
Date: Tue, 23 May 2017 16:23:08 +0200 [thread overview]
Message-ID: <87d1az64ab.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20170513033316.22395-2-ehabkost@redhat.com> (Eduardo Habkost's message of "Sat, 13 May 2017 00:33:14 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
> Keep the Popen object around to we can query its exit code later.
>
> To keep the existing 'self._popen is None' checks working, add a
> is_running() method, that will check if the process is still running.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Looks harmless enough. Have you tested the scripts using this module
still work?
next prev parent reply other threads:[~2017-05-23 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-13 3:33 [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device Eduardo Habkost
2017-05-13 3:33 ` [Qemu-devel] [PATCH v2 1/3] qemu.py: Don't set _popen=None on error/shutdown Eduardo Habkost
2017-05-23 14:23 ` Markus Armbruster [this message]
2017-05-25 18:04 ` Eduardo Habkost
2017-05-29 11:40 ` Markus Armbruster
2017-05-13 3:33 ` [Qemu-devel] [PATCH v2 2/3] qemu.py: Add QEMUMachine.exitcode() method Eduardo Habkost
2017-05-13 3:33 ` [Qemu-devel] [PATCH v2 3/3] scripts: Test script to look for -device crashes Eduardo Habkost
2017-05-23 14:52 ` Markus Armbruster
2017-05-24 16:39 ` Eduardo Habkost
2017-05-29 9:25 ` Markus Armbruster
2017-05-31 17:41 ` Eduardo Habkost
2017-05-13 4:05 ` [Qemu-devel] [PATCH v2 0/3] script for crash-testing -device no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1az64ab.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).