From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
"\\ Dr . David Alan Gilbert \\ " <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/4] migration: rename max_size to threshold_size
Date: Fri, 21 Apr 2017 11:32:47 +0200 [thread overview]
Message-ID: <87d1c6ds1s.fsf@secure.mitica> (raw)
In-Reply-To: <1491034725-23968-3-git-send-email-peterx@redhat.com> (Peter Xu's message of "Sat, 1 Apr 2017 16:18:43 +0800")
Peter Xu <peterx@redhat.com> wrote:
> In migration codes (especially in migration_thread()), max_size is used
> in many place for the threshold value that we will start to do the final
> flush and jump to the next stage to dump the whole rest things to
> destination. However its name is confusing to first readers. Let's
> rename it to "threshold_size" when proper and add a comment for it. No
> functional change is made.
>
> CC: Juan Quintela <quintela@redhat.com>
> CC: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Reviewed-by: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
next prev parent reply other threads:[~2017-04-21 9:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 8:18 [Qemu-devel] [PATCH v2 0/4] several migrations related patches Peter Xu
2017-04-01 8:18 ` [Qemu-devel] [PATCH v2 1/4] migration: set current_active_state once Peter Xu
2017-04-03 12:57 ` Philippe Mathieu-Daudé
2017-04-21 9:31 ` Juan Quintela
2017-04-01 8:18 ` [Qemu-devel] [PATCH v2 2/4] migration: rename max_size to threshold_size Peter Xu
2017-04-03 12:58 ` Philippe Mathieu-Daudé
2017-04-21 9:32 ` Juan Quintela [this message]
2017-04-01 8:18 ` [Qemu-devel] [PATCH v2 3/4] hmp: info migrate_capability format tunes Peter Xu
2017-04-03 12:59 ` Philippe Mathieu-Daudé
2017-04-21 9:33 ` Juan Quintela
2017-04-01 8:18 ` [Qemu-devel] [PATCH v2 4/4] hmp: info migrate_parameters " Peter Xu
2017-04-03 13:00 ` Philippe Mathieu-Daudé
2017-04-21 9:34 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1c6ds1s.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).