From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/2] save_vmstate: Convert to Error** from Monitor *
Date: Mon, 20 Mar 2017 19:05:26 +0100 [thread overview]
Message-ID: <87d1dbj02h.fsf@secure.mitica> (raw)
In-Reply-To: <20170320173840.3626-2-dgilbert@redhat.com> (David Alan Gilbert's message of "Mon, 20 Mar 2017 17:38:39 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> A bit more consistent and it removes one of the less necessary uses
> of cur_mon.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
> @@ -2094,16 +2094,17 @@ int save_vmstate(Monitor *mon, const char *name)
> if (name) {
> ret = bdrv_all_delete_snapshot(name, &bs1, &local_err);
> if (ret < 0) {
> - error_reportf_err(local_err,
> - "Error while deleting snapshot on device '%s': ",
> - bdrv_get_device_name(bs1));
> + error_propagate(errp, local_err);
> + error_prepend(errp,
> + "Error while deleting snapshot on device '%s': ",
> + bdrv_get_device_name(bs1));
This is just magic O:-)
next prev parent reply other threads:[~2017-03-20 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 17:38 [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's Dr. David Alan Gilbert (git)
2017-03-20 17:38 ` [Qemu-devel] [PATCH 1/2] save_vmstate: Convert to Error** from Monitor * Dr. David Alan Gilbert (git)
2017-03-20 18:05 ` Juan Quintela [this message]
2017-03-20 17:38 ` [Qemu-devel] [PATCH 2/2] wavcapture: Convert to error_report Dr. David Alan Gilbert (git)
2017-03-21 6:38 ` Gerd Hoffmann
2017-06-13 11:26 ` Dr. David Alan Gilbert
2017-03-21 12:15 ` [Qemu-devel] [PATCH 0/2 for 2.10] Remove some monitor_printf's Markus Armbruster
2017-03-21 12:22 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1dbj02h.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).