From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c0gJT-0005km-46 for qemu-devel@nongnu.org; Sat, 29 Oct 2016 22:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c0gJO-00052J-Es for qemu-devel@nongnu.org; Sat, 29 Oct 2016 22:57:35 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:47851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c0gJO-00051s-6t for qemu-devel@nongnu.org; Sat, 29 Oct 2016 22:57:30 -0400 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9U2rx4f049675 for ; Sat, 29 Oct 2016 22:57:28 -0400 Received: from e23smtp04.au.ibm.com (e23smtp04.au.ibm.com [202.81.31.146]) by mx0a-001b2d01.pphosted.com with ESMTP id 26cmnfkdpk-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Sat, 29 Oct 2016 22:57:28 -0400 Received: from localhost by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 30 Oct 2016 12:57:26 +1000 From: Nikunj A Dadhania In-Reply-To: <20161027035157.GP19918@umbus.fritz.box> References: <1477463189-26971-1-git-send-email-nikunj@linux.vnet.ibm.com> <1477463189-26971-3-git-send-email-nikunj@linux.vnet.ibm.com> <20161027035157.GP19918@umbus.fritz.box> Date: Sun, 30 Oct 2016 08:27:05 +0530 MIME-Version: 1.0 Content-Type: text/plain Message-Id: <87d1iiy266.fsf@abhimanyu.i-did-not-set--mail-host-address--so-tickle-me> Subject: Re: [Qemu-devel] [PATCH v2 2/6] bitops: fix rol/ror when shift is zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson , Richard Henderson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, sandipandas1990@gmail.com, ego@linux.vnet.ibm.com David Gibson writes: > [ Unknown signature status ] > On Wed, Oct 26, 2016 at 08:20:10AM -0700, Richard Henderson wrote: >> On 10/25/2016 11:26 PM, Nikunj A Dadhania wrote: >> > All the variants for rol/ror have a bug in case where the shift == 0. >> > For example rol32, would generate: >> > >> > return (word << 0) | (word >> 32); >> > >> > Which though works, would be flagged as a runtime error on clang's >> > sanitizer. >> > >> > Suggested-by: Richard Henderson >> > Signed-off-by: Nikunj A Dadhania >> > --- >> > include/qemu/bitops.h | 16 ++++++++-------- >> > 1 file changed, 8 insertions(+), 8 deletions(-) >> >> Reviewed-by: Richard Henderson > > This looks fine to me too, but I'm not sure if it should be going via > my tree or not. get_maintainer.pl does not help either. Regards Nikunj