From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkLp-0004uQ-33 for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:25:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aGkLl-0008O7-0A for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:25:53 -0500 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:33542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aGkLk-0008Mk-PG for qemu-devel@nongnu.org; Wed, 06 Jan 2016 04:25:48 -0500 Received: by mail-wm0-x22a.google.com with SMTP id f206so52753511wmf.0 for ; Wed, 06 Jan 2016 01:25:48 -0800 (PST) References: <1452008255-13068-1-git-send-email-drjones@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1452008255-13068-1-git-send-email-drjones@redhat.com> Date: Wed, 06 Jan 2016 09:25:45 +0000 Message-ID: <87d1tfcb52.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] trace-events: fix broken format strings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: lvivier@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org Andrew Jones writes: > Fixes compiling with --enable-trace-backends > > Signed-off-by: Andrew Jones > --- > v2: also remove trailing null strings [Laurent] Reviewed-by: Alex Bennée Tested-by: Alex Bennée > > > trace-events | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/trace-events b/trace-events > index 6f036384a84f8..98ec748270a39 100644 > --- a/trace-events > +++ b/trace-events > @@ -1799,15 +1799,15 @@ qcrypto_tls_session_new(void *session, void *creds, const char *hostname, const > vhost_user_event(const char *chr, int event) "chr: %s got event: %d" > > # linux-user/signal.c > -user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > -user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr="PRIx64"" > +user_setup_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_setup_rt_frame(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_do_rt_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > +user_do_sigreturn(void *env, uint64_t frame_addr) "env=%p frame_addr=0x%"PRIx64 > user_force_sig(void *env, int target_sig, int host_sig) "env=%p signal %d (host %d)" > user_handle_signal(void *env, int target_sig) "env=%p signal %d" > user_host_signal(void *env, int host_sig, int target_sig) "env=%p signal %d (target %d(" > user_queue_signal(void *env, int target_sig) "env=%p signal %d" > -user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr "PRIx64 " current psw.addr "PRIx64"" > +user_s390x_restore_sigregs(void *env, uint64_t sc_psw_addr, uint64_t env_psw_addr) "env=%p frame psw.addr 0x%"PRIx64 " current psw.addr 0x%"PRIx64 > > # io/task.c > qio_task_new(void *task, void *source, void *func, void *opaque) "Task new task=%p source=%p func=%p opaque=%p" -- Alex Bennée