From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: amit.shah@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/make it explicit
Date: Thu, 12 Nov 2015 18:19:37 +0100 [thread overview]
Message-ID: <87d1vfqgnq.fsf@emacs.mitica> (raw)
In-Reply-To: <1447342707-27556-1-git-send-email-dgilbert@redhat.com> (David Alan Gilbert's message of "Thu, 12 Nov 2015 15:38:27 +0000")
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Peter reported a lock error on MacOS after my a82d593b
> patch.
>
> migrate_get_current does one-time initialisation of
> a bunch of variables.
> migrate_init does reinitialisation even on a 2nd
> migrate after a cancel.
>
> The problem here was that I'd initialised the mutex
> in migrate_get_current, and the memset in migrate_init
> corrupted it.
>
> Remove the memset and replace it by explicit initialisation
> of fields that need initialising; this also turns out to be simpler
> than the old code that had to preserve some fields.
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Fixes: a82d593b
Reviewed-by: Juan Quintela <quintela@redhat.com>
Applied
prev parent reply other threads:[~2015-11-12 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:38 [Qemu-devel] [PATCH 1/1] migration_init: Fix lock initialisation/make it explicit Dr. David Alan Gilbert (git)
2015-11-12 17:19 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1vfqgnq.fsf@emacs.mitica \
--to=quintela@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).