qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.5 2/2] input: Promote 'input-send-event' to stable API
Date: Thu, 12 Nov 2015 09:23:02 +0100	[thread overview]
Message-ID: <87d1vfvd7d.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1447279028-2114-3-git-send-email-eblake@redhat.com> (Eric Blake's message of "Wed, 11 Nov 2015 14:57:08 -0700")

Eric Blake <eblake@redhat.com> writes:

> We've had 'x-input-send-event' since 2.3, with no further
> changes to the interface other than tweaks in the previous patch
> to the spelling of the enum constants ('X' and 'WheelUp' changed
> to 'x' and 'wheel-up').
>
> What's more, changing the spelling of enum constants is not easy
> to introspect prior to 2.5; so a client that was relying on the
> experimental command can't easily tell which spelling is expected.
> But 'query-commands' works in all qemu versions that supported
> the command, so renaming the command now makes it an easy thing
> to determine which spelling of the enum values to use.
>
> Thus, it's time to promote this interface to stable.

The x- goes back to commit df5b2ad:

    input: move input-send-event into experimental namespace
    
    Ongoing discussions on how we are going to specify the console,
    so tag the command as experiental so we can refine things in
    the 2.3 development cycle.
    
Have we settled "how we are going to specify the console"?  If yes,
commit, please.  If no, I'm afraid the command should stay experimental.

  reply	other threads:[~2015-11-12  8:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11 21:57 [Qemu-devel] [PATCH for-2.5 0/2] Promote 'input-send-event' to supported Eric Blake
2015-11-11 21:57 ` [Qemu-devel] [PATCH for-2.5 1/2] input: Avoid CamelCase in InputEvent enums Eric Blake
2015-11-12  8:23   ` Markus Armbruster
2015-11-12 13:24     ` Eric Blake
2015-11-11 21:57 ` [Qemu-devel] [PATCH for-2.5 2/2] input: Promote 'input-send-event' to stable API Eric Blake
2015-11-12  8:23   ` Markus Armbruster [this message]
2015-11-12  9:09     ` Gerd Hoffmann
2015-11-12 11:10       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d1vfvd7d.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).