From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50510)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zrr5k-0007hK-Eo
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:34:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zrr5h-0001J9-7M
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:34:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40378)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1Zrr5h-0001Ik-1v
	for qemu-devel@nongnu.org; Thu, 29 Oct 2015 13:34:21 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (Postfix) with ESMTPS id 8B76AAAA
	for <qemu-devel@nongnu.org>; Thu, 29 Oct 2015 17:34:20 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1446057425-16891-1-git-send-email-ehabkost@redhat.com>
	<1446057425-16891-17-git-send-email-ehabkost@redhat.com>
Date: Thu, 29 Oct 2015 18:34:17 +0100
In-Reply-To: <1446057425-16891-17-git-send-email-ehabkost@redhat.com> (Eduardo
	Habkost's message of "Wed, 28 Oct 2015 16:37:05 -0200")
Message-ID: <87d1vxvasm.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2 16/16] vl.c: Reword fw_cfg name prefix
	warning
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Andrew Jones <drjones@redhat.com>, qemu-devel@nongnu.org

Eduardo Habkost <ehabkost@redhat.com> writes:

> Make it a shorter and simpler phrase.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  vl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 6b831eb..67f75da 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2276,8 +2276,8 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp)
>          return -1;
>      }
>      if (strncmp(name, "opt/", 4) != 0) {
> -        error_report("warning: externally provided fw_cfg item names "
> -                     "should be prefixed with \"opt/\"!");
> +        error_report("warning: no \"opt/\" prefix on fw_cfg item name '%s'",
> +                     name);
>      }
>      if (nonempty_str(str)) {
>          size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */

The loss of the '!' is an improvement.  The rest perhaps not so much.