From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YT42s-0000pY-58
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 02:48:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YT42o-0006oR-3M
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 02:48:42 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59092)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1YT42n-0006nw-QX
	for qemu-devel@nongnu.org; Wed, 04 Mar 2015 02:48:38 -0500
From: Markus Armbruster <armbru@redhat.com>
References: <1425017996-6748-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<54F09FFB.2070008@redhat.com> <54F12DD7.6080208@huawei.com>
	<54F4881F.9080200@redhat.com> <54F55F8D.7040403@huawei.com>
	<54F5EDAF.7090501@redhat.com>
Date: Wed, 04 Mar 2015 08:48:23 +0100
In-Reply-To: <54F5EDAF.7090501@redhat.com> (Eric Blake's message of "Tue, 03
	Mar 2015 10:21:51 -0700")
Message-ID: <87d24p2ofs.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v2] migration: Convert 'status' of
	MigrationInfo to use an enum type
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: hangaohuai@huawei.com, zhanghailiang <zhang.zhanghailiang@huawei.com>, quintela@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, amit.shah@redhat.com, peter.huangpeng@huawei.com, dgilbert@redhat.com

Eric Blake <eblake@redhat.com> writes:

> On 03/03/2015 12:15 AM, zhanghailiang wrote:
>
>>>>
>>>> Yes, this is the reason ..., agreed, i don't like the abbreviate,
>>>> But there is already a 'MigrationState' type defined:
>>>>
>>>
>>>>
>>>> So, what about MigrationStatus ? ;)
>>>
>>> That would be fine with me.
>>>
>> 
>> Bad news, this name has also been used :(
>> 
>> In hmp.c:
>> 
>> typedef struct MigrationStatus
>
> You know, you could always rename the internal-only conflict into
> something else so that the publicly exported typename is nice.  Yeah,
> that makes the series longer,

by *two* patch hunks updating the four occurences of MigrationStatus,

>                               but it should be all mechanical
> conversions, right?  I'm not going to be too picky about what color we
> paint this bikeshed, though.

Me neither, but we shouldn't compromise on external interfaces just to
avoid a bit of internal churn.  Pick a good name, then do what it takes.