From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRKSk-0001MS-Mr for qemu-devel@nongnu.org; Fri, 27 Feb 2015 07:56:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YRKSh-0008BR-Ip for qemu-devel@nongnu.org; Fri, 27 Feb 2015 07:56:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YRKSh-0008AK-BG for qemu-devel@nongnu.org; Fri, 27 Feb 2015 07:56:11 -0500 From: Markus Armbruster References: <1423748990-9709-1-git-send-email-armbru@redhat.com> Date: Fri, 27 Feb 2015 13:56:01 +0100 In-Reply-To: <1423748990-9709-1-git-send-email-armbru@redhat.com> (Markus Armbruster's message of "Thu, 12 Feb 2015 14:49:50 +0100") Message-ID: <87d24va4ym.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, sheepdog@lists.wpkg.org, stefanha@redhat.com, kwolf@redhat.com Markus Armbruster writes: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. > > Report just one error combining the valid information from both > messages. > > Reported-by: Eric Blake > Signed-off-by: Markus Armbruster > --- > Applies on top of my "[PATCH v2 00/10] Clean up around > error_get_pretty(), qerror_report_err()", but rebasing to master would > be trivial. Applies cleanly on master now. Maintainers, please apply.