From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1X0QGy-0005W5-Fh
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:08:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1X0QGr-0000FF-GH
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:08:36 -0400
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:40893)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nikunj@linux.vnet.ibm.com>) id 1X0QGq-0000E1-DD
	for qemu-devel@nongnu.org; Fri, 27 Jun 2014 03:08:29 -0400
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <nikunj@linux.vnet.ibm.com>;
	Fri, 27 Jun 2014 12:38:23 +0530
From: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
In-Reply-To: <53AD1478.7080406@au1.ibm.com>
References: <1403851658-13128-1-git-send-email-nikunj@linux.vnet.ibm.com>
	<53AD1478.7080406@au1.ibm.com>
Date: Fri, 27 Jun 2014 12:38:09 +0530
Message-ID: <87d2dun82u.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 1/3 v3] ppc: spapr-rtas - implement os-term
	rtas call
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@au1.ibm.com>, qemu-devel@nongnu.org, agraf@suse.de
Cc: Benjamin Herrenschmidt <benh@au1.ibm.com>, qemu-ppc@nongnu.org, Anton Blanchard <anton@samba.org>

Alexey Kardashevskiy <aik@au1.ibm.com> writes:

> On 06/27/2014 04:47 PM, Nikunj A Dadhania wrote:
>> PAPR compliant guest calls this in absence of kdump. This finally
>> reaches the guest and can be handled according to the policies set by
>> higher level tools(like taking dump) for further analysis by tools like
>> crash.
>> 
>> Linux kernel calls this only when the extended version of os,term is
>> implemented to make sure that a return to the linux kernel is gauranteed.
>> 
>> CC: Benjamin Herrenschmidt <benh@au1.ibm.com>
>> CC: Anton Blanchard <anton@samba.org>
>> CC: Alexander Graf <agraf@suse.de>
>> Signed-off-by: Nikunj A Dadhania <nikunj@linux.vnet.ibm.com>
>> 
>>  static struct rtas_call {
>>      const char *name;
>>      spapr_rtas_fn fn;
>> @@ -404,6 +441,10 @@ static void core_rtas_register_types(void)
>>      spapr_rtas_register(RTAS_IBM_SET_SYSTEM_PARAMETER,
>>                          "ibm,set-system-parameter",
>>                          rtas_ibm_set_system_parameter);
>> +    spapr_rtas_register("ibm,os-term",
>> +                        rtas_ibm_os_term);
>
>
> This just won't compile, spapr_rtas_register() takes 3 parameters now.

duh, i missed that update :(

Resending

> Tokens for "ibm,os-term" and "ibm,extended-os-term" are already defined,
> just use them.
>
>
>
>> +    spapr_rtas_register("ibm,extended-os-term",
>> +                        rtas_ibm_ext_os_term);
>>  }
>>  
>>  type_init(core_rtas_register_types)
>> 
>
>
> ps. please (please) do not use my ibm's email in public :)

Sure.

Regards
Nikunj