From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41817)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1VBUdo-0007vq-DO
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 14:57:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1VBUdj-0003Cs-FQ
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 14:57:24 -0400
Received: from mail-qe0-f43.google.com ([209.85.128.43]:53223)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1VBUdj-0003Ck-BG
	for qemu-devel@nongnu.org; Mon, 19 Aug 2013 14:57:19 -0400
Received: by mail-qe0-f43.google.com with SMTP id t7so650953qeb.16
	for <qemu-devel@nongnu.org>; Mon, 19 Aug 2013 11:57:18 -0700 (PDT)
From: Mike Day <ncmike@ncultra.org>
In-Reply-To: <CAFEAcA8kYY4nNLaRG3vpx8XB_+RrUNDV2uhU85YdHqhq5_sXLQ@mail.gmail.com>
References: <1376937210-21394-1-git-send-email-ncmike@ncultra.org>
	<CAFEAcA8kYY4nNLaRG3vpx8XB_+RrUNDV2uhU85YdHqhq5_sXLQ@mail.gmail.com>
Date: Mon, 19 Aug 2013 14:57:16 -0400
Message-ID: <87d2p9ik4z.fsf@pixel.localdomain>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] Fixup some dynamic casts in the Qemu
	device tree to correspond to the QOM type-checking system.
	These patches change from using Linux kernel style upcasts to
	typesafe object oriented casts with runtime checking semantics.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org


Peter Maydell <peter.maydell@linaro.org> writes:

> On 19 August 2013 19:33, Mike Day <ncmike@ncultra.org> wrote:
>> These patches apply to Paolo Bonzini's rcu tree:
>>
>> https://github.com/bonzini/qemu/tree/rcu
>> commit 781e47bf1693a80b84eec298a6a1c7b29ab2c135
>>
>> Signed-off-by: Mike Day <ncmike@ncultra.org>
>> ---
>>  hw/misc/ivshmem.c              | 2 +-
>>  hw/pci-bridge/pci_bridge_dev.c | 6 +++---
>>  hw/pci/pci_bridge.c            | 2 +-
>>  3 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index ebcb52a..46d8c27 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -789,7 +789,7 @@ static void pci_ivshmem_uninit(PCIDevice *dev)
>>
>>  static void pci_ivshmem_instance_finalize(Object *obj)
>>  {
>> -    IVShmemState *s = IVSHMEM(dev);
>> +    IVShmemState *s = IVSHMEM(obj);
>
> This should have been a flat-out compiler error, right?

Yes, correct, but Paolo hasn't previously submitted this specific change
code afaik.

>>      if (s->migration_blocker) {
>>          migrate_del_blocker(s->migration_blocker);
>> diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c
>> index c995d5d..22caf14 100644
>> --- a/hw/pci-bridge/pci_bridge_dev.c
>> +++ b/hw/pci-bridge/pci_bridge_dev.c
>> @@ -87,7 +87,6 @@ shpc_error:
>>  bridge_error:
>>      return err;
>>  }
>> -
>
> Stray blank line change.

Thanks - and git just found it for me too. Apologies.

Mike
-- 

Mike Day | + 1 919 371-8786 | ncmike@ncultra.org
"Endurance is a Virtue"