From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPaAI-00030P-0Z for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:08:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPaAF-0006OV-Ti for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:08:53 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:58275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPaAF-0006Ee-Bz for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:08:51 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Apr 2013 01:02:28 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 5A5422CE804A for ; Wed, 10 Apr 2013 01:08:03 +1000 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r39F7taH11010460 for ; Wed, 10 Apr 2013 01:07:58 +1000 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r39F80LR020921 for ; Wed, 10 Apr 2013 01:08:00 +1000 From: Anthony Liguori In-Reply-To: References: <1365512016-21944-1-git-send-email-fred.konrad@greensocs.com> Date: Tue, 09 Apr 2013 10:07:49 -0500 Message-ID: <87d2u37nei.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v6 0/7] virtio-serial refactoring. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: amit.shah@redhat.com, cornelia.huck@de.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, KONRAD =?utf-8?B?RnI=?= =?utf-8?B?w6lkw6lyaWM=?= Peter Maydell writes: > On 9 April 2013 13:53, wrote: >> From: KONRAD Frederic >> >> This is the next part of virtio-refactoring. >> >> Basically it creates virtio-serial device which extends virtio-device. >> Then a virtio-serial can be connected on a virtio-bus. >> virtio-serial-pci, virtio-serial-s390 and virtio-serial-ccw are created too, >> they extend respectively virtio-pci, virtio-s390-device, virtio-ccw-device and >> have a virtio-serial. >> >> Tested-by: Cornelia Huck >> Reviewed-by: Cornelia Huck >> Reviewed-by: Peter Maydell > > Note to Anthony -- the way Fred has put the R-b: tags in > his cover letter here seems to confuse your 'patches' > script. 'patches apply' applies the patches and adds these > tags to every patch in the series, but > patches list id:1365512016-21944-1-git-send-email-fred.konrad@greensocs.com > status:reviewed > > produces no output. I think you need to update your patches install because it works for me: $ patches list id:1365512016-21944-1-git-send-email-fred.konrad@greensocs.com status:reviewed Message-id: 1365512016-21944-1-git-send-email-fred.konrad@greensocs.com From: Date: 2013-04-09 Tags: v6 [0/7] virtio-serial refactoring. [1/7] virtio-serial: add the virtio-serial device. [2/7] virtio-serial-pci: switch to the new API. [3/7] virtio-serial-s390: switch to the new API. [4/7] virtio-serial-ccw: switch to the new API. [5/7] virtio-serial: cleanup: init and exit functions. [6/7] virtio-serial: cleanup: use QOM casts. [7/7] virtio-serial: cleanup: remove qdev field. Regards, Anthony Liguori > > I flag this up because this patch series will probably not appear > on your radar otherwise. > > Fred: the usual convention is to put reviewed-by > tags on the patches themselves when resending, even > if the reviewers were lazy and replied to the coverletter. > > thanks > -- PMM