From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47086)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Tlrah-0001Rl-P7
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 20:40:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Tlraf-0001xb-7c
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 20:39:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:53490)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1Tlraf-0001xT-0O
	for qemu-devel@nongnu.org; Thu, 20 Dec 2012 20:39:57 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <87ehikmeqj.fsf@codemonkey.ws> (Anthony Liguori's message of
	"Thu, 20 Dec 2012 18:27:16 -0600")
References: <1356044532-8511-1-git-send-email-quintela@redhat.com>
	<87ehikmeqj.fsf@codemonkey.ws>
Date: Fri, 21 Dec 2012 02:39:54 +0100
Message-ID: <87d2y4qj2t.fsf@elfo.mitica>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PULL 00/34]  migration thread and queue
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori <anthony@codemonkey.ws> wrote:
> Juan Quintela <quintela@redhat.com> writes:
>
>> Hi
>>
>> Changes for yesterday:
>> - Paolo Acked the series
>> - Rebaso on top of today git (only conflicts were due to header re-shuffle)
>>
>> Please pull.
>>
>> [20121219]
>>
>> This is my queue for migration-thread and patches associated.  This
>> integrates review comments & code for Paolo.  This is the subset from
>> both approachs that we agreed with. rest of patches need more review
>> and are not here.
>
> This breaks migration.  Here's my test case:
>
> #!/bin/sh
>
> gzip -d -c lidb.ssmall.img.gz | \
>     ~/build/qemu/x86_64-softmmu/qemu-system-x86_64 -cdrom \
>     ~/isos/OCDC-lucid-Test-Drive-20110523_140333.iso -enable-kvm -m 2G \
>     -incoming exec:dd
>
> With lidb.ssmall.img.gz being generated from a 'migrate exec:dd of=...'
> from qemu.git just a week or two ago.
>
> I can't bisect tonight but can attempt to tomorrow.  How has this been
> tested?

I have tested with tcp, load/not-load with guests form 4GB to 16GB RAM.
Will test tomorrow with your test case.  I didn't tested exec:, though.

>
> I'm a little concerned here about the timing.  With the Christmas
> and New Years holiday we're pretty darn close to soft freeze for 1.4.
>
> Has this series gone through a full autotest run with multiple guests?

Will re-test tomorrow with autotest.

Sorry, Juan.