From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQ8g-00015H-C9 for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:41:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TJQ8b-0001t9-DW for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:41:30 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:38096) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TJQ8b-0001sz-7J for qemu-devel@nongnu.org; Wed, 03 Oct 2012 10:41:25 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 3 Oct 2012 08:41:23 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 983611FF0042 for ; Wed, 3 Oct 2012 08:41:11 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q93EeqTM005706 for ; Wed, 3 Oct 2012 08:41:12 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q93EekEB029417 for ; Wed, 3 Oct 2012 08:40:47 -0600 From: Anthony Liguori In-Reply-To: <20121003105509.463811440@amt.cnet> References: <20121003105255.972669952@amt.cnet> <20121003105509.463811440@amt.cnet> Date: Wed, 03 Oct 2012 09:40:34 -0500 Message-ID: <87d30zhb4t.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [patch 3/6] Use machine options to emulate -no-kvm-pit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel@nongnu.org, Gerd Hoffmann Cc: kvm@vger.kernel.org Marcelo Tosatti writes: > Commit e81dda195556e72f8cd294998296c1051aab30a8 from qemu-kvm.git. > > From: Jan Kiszka > > Leave the related command line option in place, just > issuing a warning that it has no function anymore. > > Signed-off-by: Marcelo Tosatti Reviewed-by: Anthony Liguori Regards, Anthony Liguori > > Index: qemu-compat-kvm/vl.c > =================================================================== > --- qemu-compat-kvm.orig/vl.c > +++ qemu-compat-kvm/vl.c > @@ -3066,7 +3066,11 @@ int main(int argc, char **argv, char **e > qemu_opts_parse(olist, "kernel_irqchip=off", 0); > break; > } > - > + case QEMU_OPTION_no_kvm_pit: { > + fprintf(stderr, "Warning: KVM PIT can no longer be disabled " > + "separately.\n"); > + break; > + } > case QEMU_OPTION_usb: > usb_enabled = 1; > break; > Index: qemu-compat-kvm/qemu-options.hx > =================================================================== > --- qemu-compat-kvm.orig/qemu-options.hx > +++ qemu-compat-kvm/qemu-options.hx > @@ -2841,6 +2841,10 @@ ETEXI > DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, > "-no-kvm-irqchip disable KVM kernel mode PIC/IOAPIC/LAPIC\n", > QEMU_ARCH_I386) > +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, > + "-no-kvm-pit disable KVM kernel mode PIT\n", > + QEMU_ARCH_I386) > + > > HXCOMM This is the last statement. Insert new options before this line! > STEXI > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html