From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:44979)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TDjV4-0001f0-19
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 18:09:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TDjV2-0002I4-Ot
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 18:09:05 -0400
Received: from e35.co.us.ibm.com ([32.97.110.153]:47246)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@us.ibm.com>) id 1TDjV2-0002Hu-He
	for qemu-devel@nongnu.org; Mon, 17 Sep 2012 18:09:04 -0400
Received: from /spool/local
	by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aliguori@us.ibm.com>;
	Mon, 17 Sep 2012 16:09:03 -0600
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 58A2E3E4003F
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 16:09:00 -0600 (MDT)
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	q8HM8o3V133812
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 16:08:56 -0600
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id q8HM8oDv002494
	for <qemu-devel@nongnu.org>; Mon, 17 Sep 2012 16:08:50 -0600
From: Anthony Liguori <aliguori@us.ibm.com>
In-Reply-To: <50579C3D.7040005@web.de>
References: <1347912880-30161-1-git-send-email-sw@weilnetz.de>
	<50579C3D.7040005@web.de>
Date: Mon, 17 Sep 2012 17:08:47 -0500
Message-ID: <87d31kb8uo.fsf@codemonkey.ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH] xtensa: Fix broken build (linker error)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>, Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org

Jan Kiszka <jan.kiszka@web.de> writes:

> On 2012-09-17 22:14, Stefan Weil wrote:
>> This configuration requires CONFIG_i8254:
>> 
>> configure --target-list=xtensa-softmmu --audio-card-list=pcspk
>
> This is wrong. The pcspk "audio card" is registered automatically for
> those targets that support it.
>
>> 
>> Reported-by: Vassili Karpov (malc) <av1474@comtv.ru>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  default-configs/xtensa-softmmu.mak   |    1 +
>>  default-configs/xtensaeb-softmmu.mak |    1 +
>>  2 files changed, 2 insertions(+)
>> 
>> diff --git a/default-configs/xtensa-softmmu.mak b/default-configs/xtensa-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensa-softmmu.mak
>> +++ b/default-configs/xtensa-softmmu.mak
>> @@ -1,5 +1,6 @@
>>  # Default configuration for Xtensa
>>  
>> +CONFIG_I8254=y
>
> And this wrong as well. xtensa does not include any speaker, nor does it
> include a PIT.

I was looking for docs and couldn't find any that indicated it contained
a PIT either.

Regards,

Anthony Liguori

>
> Jan
>
>>  CONFIG_SERIAL=y
>>  CONFIG_OPENCORES_ETH=y
>>  CONFIG_PFLASH_CFI01=y
>> diff --git a/default-configs/xtensaeb-softmmu.mak b/default-configs/xtensaeb-softmmu.mak
>> index 9d8899c..c3a263b 100644
>> --- a/default-configs/xtensaeb-softmmu.mak
>> +++ b/default-configs/xtensaeb-softmmu.mak
>> @@ -1,5 +1,6 @@
>>  # Default configuration for Xtensa
>>  
>> +CONFIG_I8254=y
>>  CONFIG_SERIAL=y
>>  CONFIG_OPENCORES_ETH=y
>>  CONFIG_PFLASH_CFI01=y
>>