From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfIN0-0006Xd-5z for qemu-devel@nongnu.org; Thu, 14 Jun 2012 18:18:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfIMy-0000Wb-Fm for qemu-devel@nongnu.org; Thu, 14 Jun 2012 18:18:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfIMy-0000WH-7m for qemu-devel@nongnu.org; Thu, 14 Jun 2012 18:18:24 -0400 From: Juan Quintela In-Reply-To: (Isaku Yamahata's message of "Mon, 4 Jun 2012 18:57:02 +0900") References: Date: Fri, 15 Jun 2012 00:18:07 +0200 Message-ID: <87d351sfkw.fsf@elfo.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 00/41] postcopy live migration Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: benoit.hudzia@gmail.com, aarcange@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, satoshi.itoh@aist.go.jp, stefanha@gmail.com, t.hirofuchi@aist.go.jp, dlaor@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, owasserm@redhat.com, avi@redhat.com, pbonzini@redhat.com Isaku Yamahata wrote: > After the long time, we have v2. This is qemu part. > The linux kernel part is sent separatedly. > > Changes v1 -> v2: > - split up patches for review > - buffered file refactored > - many bug fixes > Espcially PV drivers can work with postcopy > - optimization/heuristic > > Patches > 1 - 30: refactoring exsiting code and preparation > 31 - 37: implement postcopy itself (essential part) > 38 - 41: some optimization/heuristic for postcopy > After reviewing the changes. I think we can merge the patches 1-30. For the rest of them we still need another round of review /coding (at least we need to implement the error handling). IMHO, it makes no sense to add CONFIG_POSTCOPY, we can just compile the code in. Furthermore, we have not ifdefed the code calls on the common code. But that is just my opinion. Later, Juan.