From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0Cmh-0001nD-KC
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:03:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0Cmb-000481-SZ
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:03:07 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52394)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1S0Cmb-00047h-Jv
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:03:01 -0500
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <CAFEAcA9+7mvx7saRbJ4ygSExi4DT4ykz-r=FLEtxEa5zvEyJvw@mail.gmail.com>
	(Peter Maydell's message of "Wed, 22 Feb 2012 11:26:12 +0000")
References: <1329905754-11873-1-git-send-email-i.mitsyanko@samsung.com>
	<CAFEAcA9+7mvx7saRbJ4ygSExi4DT4ykz-r=FLEtxEa5zvEyJvw@mail.gmail.com>
Date: Wed, 22 Feb 2012 15:02:54 +0100
Message-ID: <87d397ufsh.fsf@elfo.elfo>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 0/5] VMState cleanups
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Igor Mitsyanko <i.mitsyanko@samsung.com>, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com, afaerber@suse.de

Peter Maydell <peter.maydell@linaro.org> wrote:
> On 22 February 2012 10:15, Igor Mitsyanko <i.mitsyanko@samsung.com> wrote:
>> This patchset cleans up and optimizes vmstate implementation.
>>
>> Patch 1 is a trivial bug fixing.
>> Patches 2 and 3 replaces target_phys_addr_t in pxa implementation
>> to uint32_t.
>> Patch 4 moves VMSTATE_UINTTL from hw.h to vmstate.h. Explicit dependency
>> on NEED_CPU_H is droped, I failed to understand why it was presented at all.
>
> So if we apply patches 1-3 (which all look plausible) then the only
> remaining user of VMSTATE_UINTTL is target-i386/machine.c as far as
> I can see.
>
> This leaves me wondering if we shouldn't just put it actually in
> target-i386/machine.c as a convenience macro for that specific CPU
> to avoid having to have more #ifdef TARGET_X86_64s. (I note that
> the machine.c code is already pretty inconsistent, eg lstar and
> cstar are defined as target_ulong and saved with VMSTATE_UINT64.)

With my cpu-vmstate patches, all 32/64 bit cpus use it.

ppc, sparc and mips use it.

Move it to a place that is only used for cpus makes sense, though.

> Basically VMSTATE_UINTTL seems like a bit of a dangerous thing to
> leave lying around as there aren't really very many use cases
> for it...
>
> -- PMM