From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQMku-00072m-Ai for qemu-devel@nongnu.org; Sat, 28 May 2011 12:52:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QQMkt-0005yU-6D for qemu-devel@nongnu.org; Sat, 28 May 2011 12:52:52 -0400 Received: from e28smtp03.in.ibm.com ([122.248.162.3]:42590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QQMks-0005yA-I7 for qemu-devel@nongnu.org; Sat, 28 May 2011 12:52:51 -0400 Received: from d28relay03.in.ibm.com (d28relay03.in.ibm.com [9.184.220.60]) by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id p4SGqk3r024165 for ; Sat, 28 May 2011 22:22:46 +0530 Received: from d28av01.in.ibm.com (d28av01.in.ibm.com [9.184.220.63]) by d28relay03.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p4SGqk403715274 for ; Sat, 28 May 2011 22:22:46 +0530 Received: from d28av01.in.ibm.com (loopback [127.0.0.1]) by d28av01.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p4SGqjxj012201 for ; Sat, 28 May 2011 22:22:46 +0530 From: "Aneesh Kumar K.V" In-Reply-To: <4DDFECFF.4030306@mail.berlios.de> References: <1304020934-26995-1-git-send-email-weil@mail.berlios.de> <4DB9D2DC.3080201@codemonkey.ws> <4DDFECFF.4030306@mail.berlios.de> Date: Sat, 28 May 2011 22:21:45 +0530 Message-ID: <87d3j2rcny.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v3] virtio-9p: Use relative includes for files in hw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Peter Maydell , Anthony Liguori Cc: blauwirbel@gmail.com, Venkateswararao Jujjuri , QEMU Developers On Fri, 27 May 2011 20:27:11 +0200, Stefan Weil wrote: > Am 29.04.2011 02:46, schrieb Peter Maydell: > > On 28 April 2011 21:49, Anthony Liguori wrote: > > > >> On 04/28/2011 03:02 PM, Stefan Weil wrote: > >> > >>> -$(addprefix 9pfs/, $(9pfs-nested-y)): CFLAGS += -I$(SRC_PATH)/hw/ > >>> > >> Wouldn't it be more straight forward to just do QEMU_CFLAGS +=? > >> > > There aren't any other source files in QEMU which have custom > > include paths -- why should 9pfs be a special case? > > > > -- PMM > > > > Was this an acked-by? > The patch is still uncommitted. Are there any objections? I have pulled this patch into the tree. I guess the next pull request from JV should include that. -aneesh