Re: [Qemu-devel] [PATCHv4 1/4] qmp: expose s390-specific CPU info

[Eric Blake <eblake@redhat.com>]

On 02/16/2018 06:04 AM, Viktor Mihajlovski wrote:
> Presently s390x is the only architecture not exposing specific
> CPU information via QMP query-cpus. Upstream discussion has shown
> that it could make sense to report the architecture specific CPU
> state, e.g. to detect that a CPU has been stopped.
> 
> With this change the output of query-cpus will look like this on
> s390:
> 
>     [
>       {"arch": "s390", "current": true,
>        "props": {"core-id": 0}, "cpu-state": "operating", "CPU": 0,
>        "qom_path": "/machine/unattached/device[0]",
>        "halted": false, "thread_id": 63115},
>       {"arch": "s390", "current": false,
>        "props": {"core-id": 1}, "cpu-state": "stopped", "CPU": 1,
>        "qom_path": "/machine/unattached/device[1]",
>        "halted": true, "thread_id": 63116}
>     ]

Maybe worth adding the comment that:

HMP "info cpus" is intentionally not modified, as a later patch will be 
pruning it down anyways.

> 
> Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
> Acked-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>

> ---
>   cpus.c                     |  6 ++++++
>   hw/intc/s390_flic.c        |  4 ++--
>   hw/s390x/s390-virtio-ccw.c |  2 +-
>   qapi-schema.json           | 28 +++++++++++++++++++++++++++-
>   target/s390x/cpu.c         | 24 ++++++++++++------------
>   target/s390x/cpu.h         |  7 ++-----
>   target/s390x/kvm.c         |  8 ++++----
>   target/s390x/sigp.c        | 38 +++++++++++++++++++-------------------
>   8 files changed, 73 insertions(+), 44 deletions(-)
> 

I've now read closely through the entire patch; you can upgrade my 
Acked-by into

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org