From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Eric Blake" <eblake@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>
Subject: Re: [PATCH 07/21] util: introduce 'tldr', a system data recorder for crash handling
Date: Thu, 29 Oct 2026 09:29:26 +0100 [thread overview]
Message-ID: <87ecd8gba1.fsf@pond.sub.org> (raw)
In-Reply-To: <20261015112044.1999748-8-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Thu, 15 Oct 2026 12:20:30 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> Introduce a new subsystem "tldr" aka "thrifty live data recorder"
> that will be able to continuously collect certain information at
> runtime and dump that in a crash report when QEMU exits abnormally.
> As a second use case, it will support manual triggering on interesting
> events such as guest OS panic.
What's manual about that?
> Initially the framework does nothing except print the signal
> information. Later commits will introduce broader data collection.
> This relies on the dummy siginfo_t struct for portability to Windows.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
[...]
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 49f222796ab..1c9031fba9a 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -1233,6 +1233,19 @@
> 'data': { '*pretty': 'bool',
> '*close-action': 'MonitorQMPCloseAction' } }
>
> +##
> +# @QTLDRConfigProperties:
> +# Configuration for data recorder
> +#
> +# @crash-target: fully qualified path to perserve data recorder
> +# contents on QEMU crash
What's a "fully qualified path"?
Do you mean what POSIX calls "absolute pathname"?
Please format member descriptions like this:
# @crash-target: fully qualified path to perserve data recorder
# contents on QEMU crash
> +#
> +# Since: 11.2.0
> +##
> +{ 'struct': 'QTLDRConfigProperties',
> + 'data': { '*crash-target': 'str' }
> +}
> +
> ##
> # @ObjectType:
> #
> @@ -1302,6 +1315,7 @@
> 's390-pv-guest',
> 'tdx-guest',
> 'throttle-group',
> + 'tldr-config',
> 'tls-creds-anon',
> 'tls-creds-psk',
> 'tls-creds-x509',
> @@ -1379,6 +1393,7 @@
> 'tdx-guest': 'TdxGuestProperties',
> 'thread-context': 'ThreadContextProperties',
> 'throttle-group': 'ThrottleGroupProperties',
> + 'tldr-config': 'QTLDRConfigProperties',
> 'tls-creds-anon': 'TlsCredsAnonProperties',
> 'tls-creds-psk': 'TlsCredsPskProperties',
> 'tls-creds-x509': 'TlsCredsX509Properties',
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 2f6863180b0..2f63d86b635 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -6682,6 +6682,20 @@ SRST
> ::
>
> (qemu) qom-set /objects/iothread1 poll-max-ns 100000
> +
> +
> + ``-object tldr-config,id=id,crash-target=path``
> + Creating the ``tldr-config`` object enables the thrifty live data
> + recorder, which continuously captures important information about
> + the operation of the QEMU process. When a SIGSEGV, SIGBUS,
> + SIGILL, SIGFPE or SIGABRT are seen the contents of the data
> + recorder will be dumped to the stderr stream. If the
> + ``crash-target`` parameter was given, that specifies a fully
> + qualified file path to write the dump to instead of stderr.
> +
> + The ``tldr-config`` object can be added at initial startup
> + or via QMP at runtime. Once created, however, it is not
> + permitted to disable it.
Call the object "tldr"?
> ERST
>
>
[...]
> diff --git a/util/tldr-internal.h b/util/tldr-internal.h
> new file mode 100644
> index 00000000000..193d8425eee
> --- /dev/null
> +++ b/util/tldr-internal.h
> @@ -0,0 +1,21 @@
> +/*
> + * SPDX-License-Identifier: GPL-2.0-or-later
> + *
> + * TL;DR: Thrifty Live Data Recorder
> + *
> + * Copyright (C) 2026 Red Hat Inc.
> + */
> +
> +#ifndef QEMU_TLDR_INTERNAL_H__
> +#define QEMU_TLDR_INTERNAL_H__
> +
> +#include "qemu/tldr.h"
> +
> +#define QTLDR_DUMP_LEADER "\n🚨🚨🚨 QEMU Data Recorder Start 🚨🚨🚨\n"
> +#define QTLDR_DUMP_TRAILER "\n🚨🚨🚨 QEMU Data Recorder End 🚨🚨🚨\n\n"
> +#define QTLDR_DUMP_TRIGGER_PREFIX "\n🔍 Trigger:"
> +#define QTLDR_DUMP_OPEN_ERROR "🔥 Unable to dump to '"
The emojis make the dump file UTF-8. Fine, I guess?
> +
> +void qtldr_crash_dump_internal(int fd, siginfo_t *si);
> +
> +#endif /* QEMU_TLDR_INTERNAL_H__ */
[...]
next prev parent reply other threads:[~2026-10-29 8:30 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 11:20 [PATCH 00/21] system: introduce a live data recorder facility Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 01/21] osdep: add 'ignore_value(x)' macro Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 02/21] system: move SIGBUS signal handling to signal.c Daniel P. Berrangé
2026-10-15 12:15 ` marcandre.lureau
2026-10-15 11:20 ` [PATCH 03/21] system: rename qemu_init_sigbus to qemu_init_crash_signals Daniel P. Berrangé
2026-10-15 12:15 ` marcandre.lureau
2026-10-15 11:20 ` [PATCH 04/21] system: run SIGBUS handler on alternate signal stack Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 05/21] util: expand alternate signal stack to all threads Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 06/21] osdep: provide dummy siginfo_t definition Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 07/21] util: introduce 'tldr', a system data recorder for crash handling Daniel P. Berrangé
2026-10-29 8:29 ` Markus Armbruster [this message]
2026-10-29 15:35 ` Daniel P. Berrangé
2026-10-30 8:59 ` Markus Armbruster
2026-11-17 19:52 ` Fabiano Rosas
2026-10-15 11:20 ` [PATCH 08/21] qapi: add 'tldr-dump' command for on-demand data recorder output Daniel P. Berrangé
2026-10-29 8:35 ` Markus Armbruster
2026-10-29 15:37 ` Daniel P. Berrangé
2026-11-17 19:55 ` Fabiano Rosas
2026-10-15 11:20 ` [PATCH 09/21] system: trigger TLDR crash dump on unhandled SIGBUS Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 10/21] system: simplify signal handler logic Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 11/21] main: allow SIGBUS in the main loop Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 12/21] system: enable SIGBUS handling on non-Linux platforms Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 13/21] system: enable crash dumps on SIGSEGV, SIGILL, SIGFPE and SIGABRT Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 14/21] util: introduce capture of textual messages in data recorder Daniel P. Berrangé
2026-10-29 8:49 ` Markus Armbruster
2026-11-17 20:29 ` Fabiano Rosas
2026-10-15 11:20 ` [PATCH 15/21] util: capture warnings and errors in the " Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 16/21] monitor: remove obsolete/redundant exports Daniel P. Berrangé
2026-10-29 8:51 ` Markus Armbruster
2026-10-15 11:20 ` [PATCH 17/21] monitor: capture monitor commands and events in data recorder Daniel P. Berrangé
2026-10-15 15:57 ` Dr. David Alan Gilbert
2026-10-15 16:11 ` Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 18/21] log: enable directing log messages to " Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 19/21] tests/qtest: add API to declare an expected crash signal Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 20/21] qtest: add 'crash' command to generate 'authentic' process crashes Daniel P. Berrangé
2026-10-15 11:20 ` [PATCH 21/21] tests/qtest: add test to validate data recorder on crashes Daniel P. Berrangé
2026-10-15 12:15 ` [PATCH 00/21] system: introduce a live data recorder facility marcandre.lureau
2026-10-15 12:32 ` Daniel P. Berrangé
2026-10-16 7:20 ` Marc-André Lureau
2026-10-29 17:32 ` Daniel P. Berrangé
2026-10-29 18:15 ` Marc-André Lureau
2026-10-29 18:28 ` Daniel P. Berrangé
2026-10-30 8:47 ` Marc-André Lureau
2026-10-15 17:34 ` Pierrick Bouvier
2026-10-29 17:39 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ecd8gba1.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=philmd@oss.qualcomm.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox