From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E818CC6B33 for ; Thu, 15 Oct 2026 10:36:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1xHInk-0001oI-Jf; Thu, 15 Oct 2026 06:35:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1xHIn3-00017Q-At for qemu-devel@nongnu.org; Thu, 15 Oct 2026 06:34:26 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1xHIn0-0005Tp-PO for qemu-devel@nongnu.org; Thu, 15 Oct 2026 06:34:24 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-48af27fe287so218102f8f.0 for ; Thu, 15 Oct 2026 03:34:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1792060459; x=1792665259; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:from:to:cc :subject:date:message-id:reply-to:content-type; bh=nQyOr1Z5jySAz/1/kJJ++1Mttc/PZnyiAEeZmfuQdwQ=; b=i0stPFD8OLpi3vDkXtHZvMNAJ+3s/eLitRh0OXsYdeh7YsDGjrFpBtWQDSTIl829Ge U/qtclRwtVdiCkCeL6OWQ/KKZB59xXYlThhemqdU5TeEddT1I+V0j9WauCAzuoNS49pq cdj40L4cFXm0Eg44dhOqv4LNfNM9EBWmzSqyAtwmm54AxlmvJQZulO4GiP2ISgawY841 EZrlrRtWYl5r6j8dV4swLm5QQhXeNYQKMj98CMB1y8M2Fp8F+AX1k75h/D9lzR8KCCKI q4cNvFea27+uOZzcZPyvncJI4Daaxd9y6V86UepWRCJsS4LJGgsAu2XeXMVav+/V9HRO P5kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792060459; x=1792665259; h=content-transfer-encoding:content-type:mime-version:message-id:date :user-agent:references:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nQyOr1Z5jySAz/1/kJJ++1Mttc/PZnyiAEeZmfuQdwQ=; b=vmkeQwU5nup21/97h61++GOTWzkflrVKOs+7gckvl8r+VnGML2wZtVCilbIjuFlRyo nvXbFydDbl4l890E3zZV+r8uuPaQkSW3RZvsYkiiuebC24niMr+mspz0IOX5ixzBk+C7 6DVQW9/LapGIvQS7dEZQcsqfU1vIQiHfjpVTNHxH0oFdj4bFTafOQSOIi6AcogP3a4j+ /TrJkYhSDM8BhBOQb/KV1I0skKFEzGZzlQfNftCe9rwjNsOSX/IwNa7bTgLfEKbMXx1k m8YNfxpPR+ZtWRK2PvclD9KHIwdqkpeYkWVFLlWcyHyO4VbljxG3YKyXgRGjZ2v0Mrm6 dLlg== X-Gm-Message-State: AFq9FYLd0loJ5F42DkHyWUqJsIPhlM5IMbfQ30AnRiYHxJ5GRhwQYYSq SKnZrQDYyf1uEdvLll4TWfnaddlW37+M1+rmS/ooGb2xit6G+32DPeZo86sLW5miGiQ= X-Gm-Gg: AYBFou3MS+BiZlDAkOTXaaQnqdO0C8C/dgJbaYwDb0rwkBtyl2QeT8OPof2EK/6FaCv 2zvEF6levnzPIaKWkERhe6ur7lZdcGELY/ciFec6Hp9SZx+JUx+TfyI3uaVdbnAT8VucpimxKq2 0sXISJHburYbqbXPJLjJmF1I9gk9eK1Cqs5EiVBGENmX+3ie7aLnz5N/CbiSH60FsFXOqMsYIQV Lyxt6uzJCU+G0HJlDWNAc2oWXPWOeFpaTOMSrrThKVYfoQZ8+oMKwaczFSNsDuKiWXsiRkjAdHu f1clQYP9FMYr4ltzKPOIDK0jitKEu2Wj3Nzs+Qia4eqSNocXypIbAh3JQwa2mc1Wsm44YY2VUwg vZ40XLgKcarIvbu5v7KT0UX6p/S+ZQ233oitcSwnycj7UGhX18mpCpstF7OuzVNJIqFiPcpoxKY f5LAkKg5FXBlevf6Cmd7o5WBUTY1pgSx5CogTCWOMiPoFovqYvqc7vvUstZjbvsoqcUKyE2w== X-Received: by 2002:a05:600c:3f0c:b0:4a1:85d9:13be with SMTP id 5b1f17b1804b1-4a18e498471mr397848315e9.20.1792060459135; Thu, 15 Oct 2026 03:34:19 -0700 (PDT) Received: from draig.lan ([185.124.0.158]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48df3cbb78asm4405720f8f.48.2026.10.15.03.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 03:34:18 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1CC815F869; Thu, 15 Oct 2026 11:34:17 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Ilya Leoshkevich Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Zhao Liu , Kyle Evans , Daniel P. =?utf-8?Q?Berrang=C3=A9?= , Brian Cain , Richard Henderson , Brad Smith , Ani Sinha , Christian Borntraeger , Thomas Huth , Keith Busch , Matthew Rosato , Cornelia Huck , Paolo Bonzini , Halil Pasic , John Snow , Eric Farman , Pierrick Bouvier , Anders Roxell , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , "Michael S. Tsirkin" , Warner Losh , qemu-arm@nongnu.org, Peter Maydell , Yoshinori Sato , Peter Xu , Klaus Jensen , Song Gao , qemu-s390x@nongnu.org, Laurent Vivier Subject: Re: [PATCH v2 16/16] tests/functional: add tuxrun kvm gdb test for s390x In-Reply-To: <9898cc36-2438-473c-aed5-eb1a5671c2d0@linux.ibm.com> (Ilya Leoshkevich's message of "Tue, 13 Oct 2026 21:42:03 +0200") References: <20261012170330.1144446-1-alex.bennee@linaro.org> <20261012170330.1144446-17-alex.bennee@linaro.org> <9898cc36-2438-473c-aed5-eb1a5671c2d0@linux.ibm.com> User-Agent: mu4e 1.14.4-pre6; emacs 30.1 Date: Thu, 15 Oct 2026 11:34:17 +0100 Message-ID: <87ecdrfe1i.fsf@draig.linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Ilya Leoshkevich writes: > On 10/12/26 19:03, Alex Benn=C3=A9e wrote: >> As with x86_64 we now have the bits to add a KVM gdb test. One minor >> wrinkle is the s390x only supports WP_WRITE watch points so we skip >> the other watch point tests lest we get confusing messages about >> failing to insert HW breakpoints. >> Signed-off-by: Alex Benn=C3=A9e >> --- >> tests/functional/gdb-scripts/kernel_gdb_test.py | 10 ++++++---- >> tests/functional/s390x/test_tuxrun.py | 14 ++++++++++++++ >> 2 files changed, 20 insertions(+), 4 deletions(-) >> diff --git a/tests/functional/gdb-scripts/kernel_gdb_test.py >> b/tests/functional/gdb-scripts/kernel_gdb_test.py >> index 2d62fe01f10..56f0514c943 100644 >> --- a/tests/functional/gdb-scripts/kernel_gdb_test.py >> +++ b/tests/functional/gdb-scripts/kernel_gdb_test.py >> @@ -107,11 +107,13 @@ def do_one_watch(sym, wtype, text): >> def check_watches(sym_name): >> "Watch a symbol for any access." >> - # Should hit for any read >> - do_one_watch(sym_name, gdb.WP_ACCESS, "awatch") >> + # s390 only supports write watchpoints >> + if "s390" not in gdb.selected_frame().architecture().name(): >> + # Should hit for any read >> + do_one_watch(sym_name, gdb.WP_ACCESS, "awatch") >> - # Again should hit for reads >> - do_one_watch(sym_name, gdb.WP_READ, "rwatch") >> + # Again should hit for reads >> + do_one_watch(sym_name, gdb.WP_READ, "rwatch") >> # Finally when it is written >> do_one_watch(sym_name, gdb.WP_WRITE, "watch") >> diff --git a/tests/functional/s390x/test_tuxrun.py b/tests/functional/s3= 90x/test_tuxrun.py >> index 8e0261e2b7f..528af3c08ff 100755 >> --- a/tests/functional/s390x/test_tuxrun.py >> +++ b/tests/functional/s390x/test_tuxrun.py >> @@ -19,6 +19,9 @@ class TuxRunS390xTest(TuxRunBaselineTest): >> ASSET_S390X_KERNEL =3D Asset( >> 'https://storage.tuxboot.com/kernels/6.18.54/s390/bzImage', >> '5efeb31754b211440e1595ab11355bb006fe78a2c0604ed0a8c55c4598b71= aec') >> + ASSET_S390X_VMLINUX =3D Asset( >> + 'https://storage.tuxboot.com/kernels/6.18.54/s390/vmlinux.xz', >> + '5bbd4d34e0950f88053a9bfd16078896df4b1ee1696fc2ad62488e681a6bdd= 8e') >> ASSET_S390X_ROOTFS =3D Asset( >> 'https://storage.tuxboot.com/buildroot/20260924/s390/rootfs.ex= t4.zst', >> '5ba18c4d18831c50a0c743990f7bdee1d3b520629d423c55b668d8fbbac9c= 6f5') >> @@ -42,5 +45,16 @@ def test_s390_kvm(self): >> haltmsg=3D"Requesting system halt", >> accel=3D"kvm") >> + def test_s390_kvm_gdb(self): >> + self.set_machine('s390-ccw-virtio') >> + self.require_accelerator('kvm') >> + self.wait_for_shutdown=3DFalse >> + self.common_tuxrun_gdb(kernel_asset=3Dself.ASSET_S390X_KERNEL, >> + vmlinux_asset=3Dself.ASSET_S390X_VMLINUX, >> + rootfs_asset=3Dself.ASSET_S390X_ROOTFS, >> + drive=3D"virtio-blk-ccw", >> + haltmsg=3D"Requesting system halt", >> + accel=3D"kvm") >> + >> if __name__ =3D=3D '__main__': >> TuxRunBaselineTest.main() > > This hangs unfortunately. > You need something like the following to compensate for the difference > between vmlinux ELF addresses and the actual nokaslr load address: I realise now I had it working on my s390x image and forgot to fold the changes from that tree into my local git. Fixed in v3 --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro