From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 234FF1093182 for ; Fri, 20 Mar 2026 07:45:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1w3UXR-0002k4-94; Fri, 20 Mar 2026 03:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3UXP-0002jd-5v for qemu-devel@nongnu.org; Fri, 20 Mar 2026 03:44:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1w3UXN-0002SA-KF for qemu-devel@nongnu.org; Fri, 20 Mar 2026 03:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773992690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jv2/esUQQEmiRQBGlvt4rWoAfxCaO8P4pmkEQibkse4=; b=HQe7NDDVW5SZdobdda7vQ9Hodo0XqG/OZswfGf5OzdfXgbyPNXIDHzKMqzBXMG56s3xlps WTZ3jNU3ZfG/h9Hxaq8rAMXQt2WgSWvANERGXkak5LJ7GamSZUA1i5vIbyISZ75ItHQY6f YMyofo75IWv1PlHR16ksJQQEQyIL/LM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-164-Wf9-RJBGNNa2pY34fh7WmQ-1; Fri, 20 Mar 2026 03:44:45 -0400 X-MC-Unique: Wf9-RJBGNNa2pY34fh7WmQ-1 X-Mimecast-MFC-AGG-ID: Wf9-RJBGNNa2pY34fh7WmQ_1773992684 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 497071800359; Fri, 20 Mar 2026 07:44:43 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 86E8D1800766; Fri, 20 Mar 2026 07:44:42 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 1EED221E6937; Fri, 20 Mar 2026 08:44:40 +0100 (CET) From: Markus Armbruster To: Daniel P. =?utf-8?Q?Berrang=C3=A9?= Cc: Tommaso Califano , qemu-devel@nongnu.org, kvm@vger.kernel.org, Eduardo Habkost , Zhao Liu , Marcelo Tosatti , Eric Blake , Oliver Steffen , Stefano Garzarella , Giuseppe Lettieri , Paolo Bonzini , Luigi Leonardi , Richard Henderson Subject: Re: [PATCH 1/5] i386/sev: Add sev-emulated QOM object with TCG support In-Reply-To: ("Daniel P. =?utf-8?Q?Berrang?= =?utf-8?Q?=C3=A9=22's?= message of "Thu, 19 Mar 2026 17:49:18 +0000") References: <20260317113840.33017-1-califano.tommaso@gmail.com> <20260317113840.33017-2-califano.tommaso@gmail.com> Date: Fri, 20 Mar 2026 08:44:40 +0100 Message-ID: <87eclfj66v.fsf@pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.819, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.903, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Daniel P. Berrang=C3=A9 writes: > On Tue, Mar 17, 2026 at 12:38:36PM +0100, Tommaso Califano wrote: >> With this change it is possible to run a VM with the SEV CPUID active >> adding: >>=20 >> -accel tcg \ >> -object sev-emulated,id=3Dsev0,cbitpos=3D47,reduced-phys-bits=3D1 \ >> -machine memory-encryption=3Dsev0 > > snip > >> diff --git a/qapi/qom.json b/qapi/qom.json >> index c653248f85..35cda819ec 100644 >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -1057,6 +1057,19 @@ >> '*handle': 'uint32', >> '*legacy-vm-type': 'OnOffAuto' } } >>=20=20 >> +## >> +# @SevEmulatedProperties: >> +# >> +# Properties for sev-emulated objects. >> +# This object functionally emulates AMD SEV hardware via TCG, so >> +# it does not require real hardware to run. >> +# >> +# Since: 10.1.0 >> +## >> +{ 'struct': 'SevEmulatedProperties', >> + 'base': 'SevGuestProperties', >> + 'data': {}} > > This is deriving 'sev-emulated' from 'sev-guest' which means it > supports all the properties that 'sev-guest' does, which for > the record is: Uh, I somehow misread the base as SevCommonProperties! Had I read correctly, I would've had similar questions.