From: "Alex Bennée" <alex.bennee@linaro.org>
To: Jai Arora <arorajai2798@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
pbonzini@redhat.com, peter.maydell@linaro.org
Subject: Re: [PATCH v3] accel/kvm: Turn DPRINTF macro use into tracepoints
Date: Thu, 30 Nov 2023 17:11:15 +0000 [thread overview]
Message-ID: <87edg76ua4.fsf@draig.linaro.org> (raw)
In-Reply-To: <20231130155058.237850-1-arorajai2798@gmail.com> (Jai Arora's message of "Thu, 30 Nov 2023 21:20:58 +0530")
Jai Arora <arorajai2798@gmail.com> writes:
> Patch removes DRPINTF macro and adds multiple tracepoints
> to capture different kvm events.
maybe add "We drop the DPRINTFs that don't add any additional
information than trace_kvm_run_exit already does."
Otherwise:
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
p.s.
It is helpful to add a mini-changelog bellow the --- line so reviewers
can see what changes have already been made to the patch. The git
tooling will strip this log when the maintainer applies the patches.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
prev parent reply other threads:[~2023-11-30 19:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5fd22680f77a7ec5c02e6508da6daaffc1202050>
2023-11-30 15:50 ` [PATCH v3] accel/kvm: Turn DPRINTF macro use into tracepoints Jai Arora
2023-11-30 17:11 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edg76ua4.fsf@draig.linaro.org \
--to=alex.bennee@linaro.org \
--cc=arorajai2798@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).