* Example output for query-vcpu-dirty-limit
@ 2023-03-23 10:40 Markus Armbruster
2023-03-24 1:36 ` Hyman Huang
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2023-03-23 10:40 UTC (permalink / raw)
To: Hyman Huang; +Cc: qemu-devel, Peter Xu, David Alan Gilbert
query-vcpu-dirty-limit's doc comment has an example, but it shows only
input, no output:
##
# @query-vcpu-dirty-limit:
#
# Returns information about virtual CPU dirty page rate limits, if any.
#
# Since: 7.1
#
# Example:
# {"execute": "query-vcpu-dirty-limit"}
#
##
The simplest fix is
# Example:
# -> {"execute": "query-vcpu-dirty-limit"}
# <- {"return": []}
But I'd rather show a non-empty reply here. I don't want to make one
up, because making up example output tends to result in incorrect
examples. Could you run the command for me in context where it returns
non-empty output?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Example output for query-vcpu-dirty-limit
2023-03-23 10:40 Example output for query-vcpu-dirty-limit Markus Armbruster
@ 2023-03-24 1:36 ` Hyman Huang
2023-03-24 7:07 ` Markus Armbruster
0 siblings, 1 reply; 3+ messages in thread
From: Hyman Huang @ 2023-03-24 1:36 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, Peter Xu, David Alan Gilbert
在 2023/3/23 18:40, Markus Armbruster 写道:
> query-vcpu-dirty-limit's doc comment has an example, but it shows only
> input, no output:
>
> ##
> # @query-vcpu-dirty-limit:
> #
> # Returns information about virtual CPU dirty page rate limits, if any.
> #
> # Since: 7.1
> #
> # Example:
> # {"execute": "query-vcpu-dirty-limit"}
> #
> ##
>
> The simplest fix is
>
> # Example:
> # -> {"execute": "query-vcpu-dirty-limit"}
> # <- {"return": []}
>
> But I'd rather show a non-empty reply here. I don't want to make one
> up, because making up example output tends to result in incorrect
> examples. Could you run the command for me in context where it returns
> non-empty output?
>
The following shows vm dirty-limit info with two vcpus using qmp command.
# virsh qemu-monitor-command c1b1066a-2549-076d-462d-1d97cd5de712
'{"execute":"query-vcpu-dirty-limit"}' --pretty
{
"return": [
{
"limit-rate": 60,
"current-rate": 3,
"cpu-index": 0
},
{
"limit-rate": 60,
"current-rate": 3,
"cpu-index": 1
}
],
"id": "libvirt-20155"
}
--
Best regard
Hyman Huang(黄勇)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-24 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-23 10:40 Example output for query-vcpu-dirty-limit Markus Armbruster
2023-03-24 1:36 ` Hyman Huang
2023-03-24 7:07 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).