From: "Alex Bennée" <alex.bennee@linaro.org>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>,
"John Snow" <jsnow@redhat.com>,
kraxel@redhat.com, "Beraldo Leal" <bleal@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
pbonzini@redhat.com, "Eric Farman" <farman@linux.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
thuth@redhat.com, "Halil Pasic" <pasic@linux.ibm.com>,
"Michael Roth" <michael.roth@amd.com>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Ed Maste" <emaste@freebsd.org>
Subject: Re: [PATCH v4 6/8] Update lcitool and fedora to 37
Date: Thu, 19 Jan 2023 12:29:53 +0000 [thread overview]
Message-ID: <87edrqzouq.fsf@linaro.org> (raw)
In-Reply-To: <20230110132700.833690-7-marcandre.lureau@redhat.com>
marcandre.lureau@redhat.com writes:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Fedora 35 is EOL.
>
> Update to upstream lcitool, that dropped f35 and added f37.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/docker/dockerfiles/fedora-win32-cross.docker | 4 ++--
> tests/docker/dockerfiles/fedora-win64-cross.docker | 4 ++--
> tests/docker/dockerfiles/fedora.docker | 4 ++--
> tests/lcitool/libvirt-ci | 2 +-
> tests/lcitool/refresh | 6 +++---
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/fedora-win32-cross.docker b/tests/docker/dockerfiles/fedora-win32-cross.docker
> index 75383ba185..cc5d1ac4be 100644
> --- a/tests/docker/dockerfiles/fedora-win32-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win32-cross.docker
> @@ -1,10 +1,10 @@
> # THIS FILE WAS AUTO-GENERATED
> #
> -# $ lcitool dockerfile --layers all --cross mingw32 fedora-35 qemu
> +# $ lcitool dockerfile --layers all --cross mingw32 fedora-37 qemu
> #
> # https://gitlab.com/libvirt/libvirt-ci
>
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37
>
> RUN dnf install -y nosync && \
> echo -e '#!/bin/sh\n\
> diff --git a/tests/docker/dockerfiles/fedora-win64-cross.docker b/tests/docker/dockerfiles/fedora-win64-cross.docker
> index 98c03dc13b..cabbf4edfc 100644
> --- a/tests/docker/dockerfiles/fedora-win64-cross.docker
> +++ b/tests/docker/dockerfiles/fedora-win64-cross.docker
> @@ -1,10 +1,10 @@
> # THIS FILE WAS AUTO-GENERATED
> #
> -# $ lcitool dockerfile --layers all --cross mingw64 fedora-35 qemu
> +# $ lcitool dockerfile --layers all --cross mingw64 fedora-37 qemu
> #
> # https://gitlab.com/libvirt/libvirt-ci
>
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37
>
> RUN dnf install -y nosync && \
> echo -e '#!/bin/sh\n\
> diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker
> index d200c7fc10..f44b005000 100644
> --- a/tests/docker/dockerfiles/fedora.docker
> +++ b/tests/docker/dockerfiles/fedora.docker
> @@ -1,10 +1,10 @@
> # THIS FILE WAS AUTO-GENERATED
> #
> -# $ lcitool dockerfile --layers all fedora-35 qemu
> +# $ lcitool dockerfile --layers all fedora-37 qemu
> #
> # https://gitlab.com/libvirt/libvirt-ci
>
> -FROM registry.fedoraproject.org/fedora:35
> +FROM registry.fedoraproject.org/fedora:37
This breaks the oss fuzz build:
Testing ./build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target- ...
=================================================================
==5695==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 8 byte(s) in 1 object(s) allocated from:
#0 0x559931c2a458 in operator new(unsigned long) (/builds/stsquad/qemu/build-oss-fuzz/DEST_DIR/qemu-fuzz-i386-target-+0xcff458) (BuildId: 4656f7dd1ff6e2faf418a79279f4e92db931ba28)
#1 0x7f89125205b7 (/lib64/libtcmalloc_minimal.so.4+0xe5b7) (BuildId: 8eab2cfc91caa7a82e480465400218310b7a341c)
#2 0x7f8917d24cdd in call_init /usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:70:3
#3 0x7f8917d24cdd in call_init /usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:26:1
#4 0x7f8917d24dcb in _dl_init /usr/src/debug/glibc-2.36-9.fc37.x86_64/elf/dl-init.c:117:5
#5 0x7f8917d3b8df in _dl_start_user (/lib64/ld-linux-x86-64.so.2+0x1b8df) (BuildId: bb6fec54c7521fddc569a2f4e141dfb97bf3acbe)
SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s).
Cleaning up project directory and file based variables
The actual cause is that libglusterfs-devel pulls in gperftools-libs:
[root@c0ca1c50f5cc /]# yum install libglusterfs-devel
Last metadata expiration check: 0:04:40 ago on Thu 19 Jan 2023 12:24:51 PM UTC.
Dependencies resolved.
============================================================================================================================================================================= Package Architecture Version Repository Size
=============================================================================================================================================================================Installing:
libglusterfs-devel x86_64 10.3-1.fc37 fedora 129 k
Installing dependencies:
gperftools-libs x86_64 2.9.1-4.fc37 fedora 307 k
libgfrpc-devel x86_64 10.3-1.fc37 fedora 46 k
libgfrpc0 x86_64 10.3-1.fc37 fedora 59 k
libgfxdr-devel x86_64 10.3-1.fc37 fedora 9.9 k
libgfxdr0 x86_64 10.3-1.fc37 fedora 31 k
libglusterfs0 x86_64 10.3-1.fc37 fedora 327 k
Transaction Summary
=============================================================================================================================================================================Install 7 Packages
Which brings in gperftools-libs an tcmalloc which then gets in the way
of our build. So either we drop glusterfs on fedora builds or we need
some way to avoid tcmalloc getting in the way.
To try and get the rest of the PR out of the way I think we should drop
this for now unless anyone has an easy solution?
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
next prev parent reply other threads:[~2023-01-19 12:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:26 [PATCH v4 0/8] Fix win32/msys2 shader compilation & update lcitool deps marcandre.lureau
2023-01-10 13:26 ` [PATCH v4 1/8] build-sys: fix crlf-ending C code marcandre.lureau
2023-01-10 13:26 ` [PATCH v4 2/8] .gitlab-ci.d/windows: do not disable opengl marcandre.lureau
2023-01-10 13:26 ` [PATCH v4 3/8] configure: replace Perl usage with sed marcandre.lureau
2023-01-10 13:35 ` Daniel P. Berrangé
2023-01-10 13:26 ` [PATCH v4 4/8] meson: replace Perl usage with Python marcandre.lureau
2023-01-10 13:33 ` Daniel P. Berrangé
2023-01-10 13:26 ` [PATCH v4 5/8] docs: drop texinfo options marcandre.lureau
2023-01-10 13:35 ` Daniel P. Berrangé
2023-01-10 13:26 ` [PATCH v4 6/8] Update lcitool and fedora to 37 marcandre.lureau
2023-01-19 12:29 ` Alex Bennée [this message]
2023-01-10 13:26 ` [PATCH v4 7/8] lcitool: drop perl from QEMU project/dependencies marcandre.lureau
2023-01-10 13:36 ` Daniel P. Berrangé
2023-01-10 13:27 ` [PATCH v4 8/8] lcitool: drop texinfo " marcandre.lureau
2023-01-10 13:37 ` Daniel P. Berrangé
2023-01-16 10:06 ` Alex Bennée
2023-01-16 10:21 ` Marc-André Lureau
2023-01-16 14:52 ` Alex Bennée
2023-01-16 10:46 ` Daniel P. Berrangé
2023-01-16 12:09 ` Alex Bennée
2023-01-10 16:35 ` [PATCH v4 0/8] Fix win32/msys2 shader compilation & update lcitool deps Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edrqzouq.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=crosa@redhat.com \
--cc=david@redhat.com \
--cc=emaste@freebsd.org \
--cc=farman@linux.ibm.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=lwhsu@freebsd.org \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).