From: Markus Armbruster <armbru@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: kwolf@redhat.com, fam@euphon.net, berrange@redhat.com,
qemu-block@nongnu.org, michael.roth@amd.com, mtosatti@redhat.com,
qemu-devel@nongnu.org, eduardo@habkost.net, hreitz@redhat.com,
stefanha@redhat.com, pbonzini@redhat.com, eblake@redhat.com
Subject: Re: [PATCH v5 0/3] util/thread-pool: Expose minimun and maximum size
Date: Mon, 25 Apr 2022 07:22:09 +0200 [thread overview]
Message-ID: <87ee1lrb3y.fsf@pond.sub.org> (raw)
In-Reply-To: <20220422163857.703111-1-nsaenzju@redhat.com> (Nicolas Saenz Julienne's message of "Fri, 22 Apr 2022 18:38:54 +0200")
Nicolas Saenz Julienne <nsaenzju@redhat.com> writes:
> As discussed on the previous RFC[1] the thread-pool's dynamic thread
> management doesn't play well with real-time and latency sensitive
> systems. This series introduces a set of controls that'll permit
> achieving more deterministic behaviours, for example by fixing the
> pool's size.
>
> We first introduce a new common interface to event loop configuration by
> moving iothread's already available properties into an abstract class
> called 'EventLooopBackend' and have both 'IOThread' and the newly
> created 'MainLoop' inherit the properties from that class.
>
> With this new configuration interface in place it's relatively simple to
> introduce new options to fix the even loop's thread pool sizes. The
> resulting QAPI looks like this:
>
> -object main-loop,id=main-loop,thread-pool-min=1,thread-pool-max=1
>
> Note that all patches are bisect friendly and pass all the tests.
>
> [1] https://patchwork.ozlabs.org/project/qemu-devel/patch/20220202175234.656711-1-nsaenzju@redhat.com/
>
> @Stefan I kept your Signed-off-by, since the changes trivial/not
> thread-pool related
With the doc nit in PATCH 2 addressed, QAPI schema
Acked-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2022-04-25 5:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 16:38 [PATCH v5 0/3] util/thread-pool: Expose minimun and maximum size Nicolas Saenz Julienne
2022-04-22 16:38 ` [PATCH v5 1/3] Introduce event-loop-base abstract class Nicolas Saenz Julienne
2022-04-22 16:38 ` [PATCH v5 2/3] util/main-loop: Introduce the main loop into QOM Nicolas Saenz Julienne
2022-04-25 5:21 ` Markus Armbruster
2022-04-22 16:38 ` [PATCH v5 3/3] util/event-loop-base: Introduce options to set the thread pool size Nicolas Saenz Julienne
2022-04-25 5:22 ` Markus Armbruster [this message]
2022-04-25 7:49 ` [PATCH v5 0/3] util/thread-pool: Expose minimun and maximum size Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee1lrb3y.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=nsaenzju@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).