* [PATCH] migration/ram: clean up unused comment.
@ 2022-01-17 2:30 Xu Zheng
2022-01-26 21:00 ` Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Xu Zheng @ 2022-01-17 2:30 UTC (permalink / raw)
To: quintela, dgilbert; +Cc: qemu-devel, Mao Zhongyi, Xu Zheng
Just a removal of an unused comment.
a0a8aa147aa did many fixes and removed the parameter named "ms", but forget to remove the corresponding comment in function named "ram_save_host_page".
Signed-off-by: Xu Zheng <xuzheng@cmss.chinamobile.com>
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
migration/ram.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 57efa67f20..96944f0c70 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2188,7 +2188,6 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
* Returns the number of pages written or negative on error
*
* @rs: current RAM state
- * @ms: current migration state
* @pss: data about the page we want to send
* @last_stage: if we are at the completion stage
*/
--
2.18.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] migration/ram: clean up unused comment.
2022-01-17 2:30 [PATCH] migration/ram: clean up unused comment Xu Zheng
@ 2022-01-26 21:00 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2022-01-26 21:00 UTC (permalink / raw)
To: Xu Zheng; +Cc: dgilbert, Mao Zhongyi, qemu-devel
Xu Zheng <xuzheng@cmss.chinamobile.com> wrote:
> Just a removal of an unused comment.
> a0a8aa147aa did many fixes and removed the parameter named "ms", but
> forget to remove the corresponding comment in function named
> "ram_save_host_page".
>
> Signed-off-by: Xu Zheng <xuzheng@cmss.chinamobile.com>
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued.
> ---
> migration/ram.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 57efa67f20..96944f0c70 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2188,7 +2188,6 @@ static int ram_save_target_page(RAMState *rs, PageSearchStatus *pss,
Somehow git diff got confised here, and shows ram_save_target_page where
it is ram_save_host_page(). I fixued it manually.
> * Returns the number of pages written or negative on error
> *
> * @rs: current RAM state
> - * @ms: current migration state
> * @pss: data about the page we want to send
> * @last_stage: if we are at the completion stage
> */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-26 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-17 2:30 [PATCH] migration/ram: clean up unused comment Xu Zheng
2022-01-26 21:00 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).