From: "Alex Bennée" <alex.bennee@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>
Cc: "Brian Cain" <bcain@quicinc.com>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test
Date: Wed, 03 Nov 2021 13:31:53 +0000 [thread overview]
Message-ID: <87ee7xjqlv.fsf@linaro.org> (raw)
In-Reply-To: <SN4PR0201MB880807096E4D98700320E4FFDE8B9@SN4PR0201MB8808.namprd02.prod.outlook.com>
Taylor Simpson <tsimpson@quicinc.com> writes:
>> -----Original Message-----
>> From: Alex Bennée <alex.bennee@linaro.org>
>> Sent: Tuesday, November 2, 2021 11:42 AM
>> To: Taylor Simpson <tsimpson@quicinc.com>
>> Cc: Richard Henderson <richard.henderson@linaro.org>; Philippe Mathieu-
>> Daudé <f4bug@amsat.org>; qemu-devel@nongnu.org;
>> peter.maydell@linaro.org
>> Subject: Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test
>>
>> Taylor Simpson <tsimpson@quicinc.com> writes:
>>
>> >> -----Original Message-----
>> >> From: Richard Henderson <richard.henderson@linaro.org>
>> >> Sent: Monday, November 1, 2021 10:03 AM
>> >> To: Philippe Mathieu-Daudé <f4bug@amsat.org>; Taylor Simpson
>> >> <tsimpson@quicinc.com>; qemu-devel@nongnu.org; Alex Bennée
>> >> <alex.bennee@linaro.org>
>> >> Cc: peter.maydell@linaro.org
>> >> Subject: Re: [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc
>> >> test
>> >>
>> >> On 11/1/21 10:17 AM, Philippe Mathieu-Daudé wrote:
>> >> > On 11/1/21 15:09, Taylor Simpson wrote:
>> >> >> Plan-A should be to update the container with the new toolchain.
>> >> >
>> >> > IIUC Richard is going with Plan-A: wait Alex queue get merged, then
>> >> > retry merging this pull request.
>> >>
>> >> Correct.
>> >
>> > Agreed. Just let me know if Alex isn't going to get the new toolchain
>> > merged in time, and I can go to plan B.
>>
>> The PR has been a pain to get working but it should be in soon. Just need to
>> work out why the signals test has broken between master and my
>> PR:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/1739288510#L1318
>>
>> vs
>>
>> https://gitlab.com/stsquad/qemu/-/jobs/1740048034#L1316
>>
>> Could it be a toolchain thing?
>
> Not likely a toolchain problem. If I can access both of the signals
> binaries, I can confirm.
Testing against two signals binaries I see a 4-7% failure rate against the
new binary versus the original pre-toolchain change one. That's not to
say the binary is broken - it could be a subtle change that exacerbated
our existing poor signals support.
https://transfer.sh/xA2ejk/signals.old (pre-toolchain change)
https://transfer.sh/vSsn5s/signals
something in the CI ensures it fails much more reliably as U can't get
it to pass on a retry.
>
> Richard was doing some changes in qemu related to signals. Are his
> changes available in both repos?
I've tested against master and rth/tgt-next (742f07628c0)
>
>
> Taylor
--
Alex Bennée
next prev parent reply other threads:[~2021-11-03 13:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-31 16:42 [PULL 00/30] Hexagon HVX (target/hexagon) patch series Taylor Simpson
2021-10-31 16:42 ` [PULL 01/30] Hexagon HVX (target/hexagon) README Taylor Simpson
2021-10-31 16:42 ` [PULL 02/30] Hexagon HVX (target/hexagon) add Hexagon Vector eXtensions (HVX) to core Taylor Simpson
2021-10-31 16:42 ` [PULL 03/30] Hexagon HVX (target/hexagon) register names Taylor Simpson
2021-10-31 16:42 ` [PULL 04/30] Hexagon HVX (target/hexagon) instruction attributes Taylor Simpson
2021-10-31 16:42 ` [PULL 05/30] Hexagon HVX (target/hexagon) macros Taylor Simpson
2021-10-31 16:42 ` [PULL 06/30] Hexagon HVX (target/hexagon) import macro definitions Taylor Simpson
2021-10-31 16:42 ` [PULL 07/30] Hexagon HVX (target/hexagon) semantics generator Taylor Simpson
2021-10-31 16:42 ` [PULL 08/30] Hexagon HVX (target/hexagon) semantics generator - part 2 Taylor Simpson
2021-10-31 16:42 ` [PULL 09/30] Hexagon HVX (target/hexagon) C preprocessor for decode tree Taylor Simpson
2021-10-31 16:42 ` [PULL 10/30] Hexagon HVX (target/hexagon) instruction utility functions Taylor Simpson
2021-10-31 16:42 ` [PULL 11/30] Hexagon HVX (target/hexagon) helper functions Taylor Simpson
2021-10-31 16:42 ` [PULL 12/30] Hexagon HVX (target/hexagon) TCG generation Taylor Simpson
2021-10-31 16:42 ` [PULL 13/30] Hexagon HVX (target/hexagon) helper overrides infrastructure Taylor Simpson
2021-10-31 16:42 ` [PULL 14/30] Hexagon HVX (target/hexagon) helper overrides for histogram instructions Taylor Simpson
2021-10-31 16:42 ` [PULL 15/30] Hexagon HVX (target/hexagon) helper overrides - vector assign & cmov Taylor Simpson
2021-10-31 16:42 ` [PULL 16/30] Hexagon HVX (target/hexagon) helper overrides - vector add & sub Taylor Simpson
2021-10-31 16:42 ` [PULL 17/30] Hexagon HVX (target/hexagon) helper overrides - vector shifts Taylor Simpson
2021-10-31 16:42 ` [PULL 18/30] Hexagon HVX (target/hexagon) helper overrides - vector max/min Taylor Simpson
2021-10-31 16:42 ` [PULL 19/30] Hexagon HVX (target/hexagon) helper overrides - vector logical ops Taylor Simpson
2021-10-31 16:42 ` [PULL 20/30] Hexagon HVX (target/hexagon) helper overrides - vector compares Taylor Simpson
2021-10-31 16:43 ` [PULL 21/30] Hexagon HVX (target/hexagon) helper overrides - vector splat and abs Taylor Simpson
2021-10-31 16:43 ` [PULL 22/30] Hexagon HVX (target/hexagon) helper overrides - vector loads Taylor Simpson
2021-10-31 16:43 ` [PULL 23/30] Hexagon HVX (target/hexagon) helper overrides - vector stores Taylor Simpson
2021-10-31 16:43 ` [PULL 24/30] Hexagon HVX (target/hexagon) import semantics Taylor Simpson
2021-10-31 16:43 ` [PULL 25/30] Hexagon HVX (target/hexagon) instruction decoding Taylor Simpson
2021-10-31 16:43 ` [PULL 26/30] Hexagon HVX (target/hexagon) import instruction encodings Taylor Simpson
2021-10-31 16:43 ` [PULL 27/30] Hexagon HVX (tests/tcg/hexagon) vector_add_int test Taylor Simpson
2021-10-31 16:43 ` [PULL 28/30] Hexagon HVX (tests/tcg/hexagon) hvx_misc test Taylor Simpson
2021-11-01 10:33 ` Philippe Mathieu-Daudé
2021-11-01 13:43 ` Richard Henderson
2021-11-01 14:09 ` Taylor Simpson
2021-11-01 14:17 ` Philippe Mathieu-Daudé
2021-11-01 15:02 ` Richard Henderson
2021-11-02 16:05 ` Taylor Simpson
2021-11-02 16:41 ` Alex Bennée
2021-11-02 16:53 ` Taylor Simpson
2021-11-03 13:31 ` Alex Bennée [this message]
2021-11-03 15:22 ` Hexagon toolchain update vs linux-user signals Richard Henderson
2021-10-31 16:43 ` [PULL 29/30] Hexagon HVX (tests/tcg/hexagon) scatter_gather test Taylor Simpson
2021-10-31 16:43 ` [PULL 30/30] Hexagon HVX (tests/tcg/hexagon) histogram test Taylor Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee7xjqlv.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bcain@quicinc.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).