qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/7] tests/docker: Simplify debian-all-test-cross
Date: Mon, 18 Oct 2021 11:54:42 +0100	[thread overview]
Message-ID: <87ee8i1u2x.fsf@linaro.org> (raw)
In-Reply-To: <20211014224435.2539547-3-richard.henderson@linaro.org>


Richard Henderson <richard.henderson@linaro.org> writes:

> The base debian10 image contains enough to build qemu;
> we do not need to repeat that within the new image.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tests/docker/dockerfiles/debian-all-test-cross.docker | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/tests/docker/dockerfiles/debian-all-test-cross.docker b/tests/docker/dockerfiles/debian-all-test-cross.docker
> index dedcea58b4..b185b7c15a 100644
> --- a/tests/docker/dockerfiles/debian-all-test-cross.docker
> +++ b/tests/docker/dockerfiles/debian-all-test-cross.docker
> @@ -8,11 +8,6 @@
>  #
>  FROM qemu/debian10
>  
> -# What we need to build QEMU itself
> -RUN apt update && \
> -    DEBIAN_FRONTEND=noninteractive eatmydata \
> -    apt build-dep -yy qemu
> -
>  # Add the foreign architecture we want and install dependencies
>  RUN DEBIAN_FRONTEND=noninteractive eatmydata \
>          apt install -y --no-install-recommends \

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée


  reply	other threads:[~2021-10-18 10:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 22:44 [PATCH 0/7] tests: docker images for hexagon, nios2, microblaze Richard Henderson
2021-10-14 22:44 ` [PATCH 1/7] tests/docker: Use apt build-dep in debian10 Richard Henderson
2021-10-18 10:53   ` Alex Bennée
2021-10-14 22:44 ` [PATCH 2/7] tests/docker: Simplify debian-all-test-cross Richard Henderson
2021-10-18 10:54   ` Alex Bennée [this message]
2021-10-18 11:14     ` Philippe Mathieu-Daudé
2021-10-18 11:33       ` Alex Bennée
2021-11-02 12:24         ` Alex Bennée
2021-11-02 14:33           ` Philippe Mathieu-Daudé
2021-10-14 22:44 ` [PATCH 3/7] tests/docker: Update debian-hexagon-cross to a newer toolchain Richard Henderson
2021-10-14 22:44 ` [PATCH 4/7] gitlab-ci: Remove special casing for hexagon testing Richard Henderson
2021-10-14 22:44 ` [PATCH 5/7] tests/docker: Add debian-nios2-cross image Richard Henderson
2021-10-14 22:44 ` [PATCH 6/7] tests/docker: Add debian-microblaze-cross image Richard Henderson
2021-10-14 22:44 ` [PATCH 7/7] tests/tcg: Enable container_cross_cc for microblaze Richard Henderson
2021-10-18 10:57   ` Alex Bennée
2021-10-19 14:46 ` [PATCH 0/7] tests: docker images for hexagon, nios2, microblaze Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee8i1u2x.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).