From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 046A9C4338F for ; Tue, 10 Aug 2021 11:57:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CE5E60EBC for ; Tue, 10 Aug 2021 11:57:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5CE5E60EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:44782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDQNj-0004t7-Ad for qemu-devel@archiver.kernel.org; Tue, 10 Aug 2021 07:57:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQMw-0003Tx-PJ for qemu-devel@nongnu.org; Tue, 10 Aug 2021 07:56:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:54922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDQMv-0000jm-C2 for qemu-devel@nongnu.org; Tue, 10 Aug 2021 07:56:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628596588; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=5prZoq1EHeBQ/qRgX1Thye/qV/0NuiVmEZKhrkN0qZM=; b=bCFSrkJVEIe1lBcKF5IM7LKiRiwt970pzG0kK5ahHQ6NeT7PQZzw/lNywi1Q+aWGslOBVo 6qZeuIgq2WCaBGyz/qQAk335jbu7gvI4YLZzxb3YBY9aRk8GM+M7/RUdA6IyMTT0GF0s7Z KquoZSulNB1iwHBgHjLHuV8/3M+PHTA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-ZpdYqXtmNDqU1VOoUQvv8g-1; Tue, 10 Aug 2021 07:56:27 -0400 X-MC-Unique: ZpdYqXtmNDqU1VOoUQvv8g-1 Received: by mail-wr1-f71.google.com with SMTP id m5-20020a5d6a050000b0290154e83dce73so2057634wru.19 for ; Tue, 10 Aug 2021 04:56:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:reply-to:date:message-id:mime-version; bh=5prZoq1EHeBQ/qRgX1Thye/qV/0NuiVmEZKhrkN0qZM=; b=ncioi30f9AppqNfd2FflKPwoCsJyAdD0l1egL17bd5QTWkiZtQQ+khVHi6FMWPj4Ws yAA2svIKZU0iYIUmZ0DwhmVkVzxRGLwjoNshbCMth/y7oo14g9HE0+Fv+x/9wHFEEcZy 0KhvJwanxSv/qyzA/Xw54417ffsdzvudNtg9qbJVBQrzHiBydL4uYU+Gykwbm7jGEk3v /oUl6BIwoGYRcux7qToluuZXYk/zWuKyytKmz3IhaceETO3AFDj9yCyI24tiWAM0eYIO mk+kr+uVbmhKiAZAhV5GXQzFQAyOCnTeh0lPsVbkD57SIukQCaS7QHj7EBPIPYRYWBQO eaIA== X-Gm-Message-State: AOAM5309oLtjfixhsgR3xTjerCKGYh23PbJPXyjdPwSf5Vq87m9PtV82 EQ3eWpavMVaGPyj0ZWSAYXjTgA2juNC8DO6xYROWMJ1WUdCE1r4MvhA+pXPXpFj6oxN4is1Nygw xRypBlwKxdqYzIsU= X-Received: by 2002:a7b:cc8b:: with SMTP id p11mr4283224wma.25.1628596586422; Tue, 10 Aug 2021 04:56:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfbg0eLxvdQ2AVGPY12Gl7y6VDE5UDcz1RxovMdHOCEYd9VgRyqOUvl++whJAel75rt+uU4w== X-Received: by 2002:a7b:cc8b:: with SMTP id p11mr4283207wma.25.1628596586232; Tue, 10 Aug 2021 04:56:26 -0700 (PDT) Received: from localhost (62.83.194.64.dyn.user.ono.com. [62.83.194.64]) by smtp.gmail.com with ESMTPSA id g5sm2445853wmh.31.2021.08.10.04.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Aug 2021 04:56:25 -0700 (PDT) From: Juan Quintela To: Eduardo Habkost Subject: Re: [PATCH for-6.2 02/12] qom: Use DEVICE_*CLASS instead of OBJECT_*CLASS In-Reply-To: <20210806211127.646908-3-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:17 -0400") References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-3-ehabkost@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) Date: Tue, 10 Aug 2021 13:56:25 +0200 Message-ID: <87eeb11pjq.fsf@secure.mitica> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=quintela@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=170.10.133.124; envelope-from=quintela@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.704, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: "Daniel P. Berrange" , "Michael S. Tsirkin" , Markus Armbruster , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , Gerd Hoffmann , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Eduardo Habkost wrote: > There are multiple functions where OBJECT_GET_CLASS or > OBJECT_CLASS_CHECK are being used directly for > DeviceClass/TYPE_DEVICE, instead of the DEVICE_GET_CLASS or > DEVICE_CLASS wrappers. There's no reason to not use the > wrappers, so use them. > > Signed-off-by: Eduardo Habkost Reviewed-by: Juan Quintela > - DeviceClass *dc = OBJECT_CLASS_CHECK(DeviceClass, list->data, > - TYPE_DEVICE); > + DeviceClass *dc = DEVICE_CLASS(list->data); Finding where DEVICE_CLASS is defined is .... interesting.