From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: peter.maydell@linaro.org, danielhb413@gmail.com, groug@kaod.org,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
bauerman@linux.ibm.com,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PULL 19/33] mips/cps: Use start-powered-off CPUState property
Date: Wed, 07 Oct 2020 11:47:29 +0100 [thread overview]
Message-ID: <87eema1fem.fsf@linaro.org> (raw)
In-Reply-To: <1ffe5f96-be5e-f151-a1fe-7c9f4f765b4d@amsat.org>
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> On 10/7/20 11:28 AM, Alex Bennée wrote:
>>
>> David Gibson <david@gibson.dropbear.id.au> writes:
>>
>>> From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>>>
>>> Instead of setting CPUState::halted to 1 in main_cpu_reset(), use the
>>> start-powered-off property which makes cpu_common_reset() initialize it
>>> to 1 in common code.
>>>
>>> Also change creation of CPU object from cpu_create() to object_new() and
>>> qdev_realize_and_unref() because cpu_create() realizes the CPU and it's not
>>> possible to set a property after the object is realized.
>>>
>>> Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
>>> Message-Id: <20200826055535.951207-6-bauerman@linux.ibm.com>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
>>
>> I've finally bisected the breakage in check-acceptance to this patch:
>>
>> 10:24:09 [alex.bennee@hackbox2:~/l/q/b/bisect] (102ca966…)|BISECTING|✔ + ./tests/venv/bin/avocado run tests/acceptance/machine_mips_malta.py
>> /home/alex.bennee/lsrc/qemu.git/builds/bisect/tests/venv/lib/python3.6/site-packages/avocado/plugins/run.py:214: FutureWarning: The following arguments will be changed to boolean soon: sysinfo, output-check, failfast, keep-tmp and ignore-missing-references.
>> FutureWarning)
>> JOB ID : 1a71a0a81cf9fb9a387d2ab105f8196a26cab84e
>> JOB LOG : /home/alex.bennee/avocado/job-results/job-2020-10-07T10.24-1a71a0a/job.log
>> (1/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_1core: PASS (5.70 s)
>> (2/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_7cores: INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status: ERROR\n{'name': '2-tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_7cores',
>> 'logdir': '/home/alex.bennee/avocado/job-r... (28.91 s)
>> (3/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_8cores: INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status: ERROR\n{'name': '3-tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_8cores',
>> 'logdir': '/home/alex.bennee/avocado/job-r... (30.58 s)
>> RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 2 | CANCEL 0
>> JOB TIME : 70.12 s
>> 10:25:27 [alex.bennee@hackbox2:~/l/q/b/bisect] (102ca966…)|BISECTING|✔ 8 + make -j30
>> make[1]: Entering directory '/home/alex.bennee/lsrc/qemu.git/slirp'
>> make[1]: Nothing to be done for 'all'.
>> make[1]: Leaving directory '/home/alex.bennee/lsrc/qemu.git/slirp'
>> Generating qemu-version.h with a meson_exe.py custom command
>> Compiling C object libqemu-mips64el-softmmu.fa.p/hw_mips_cps.c.o
>> Compiling C object libqemu-mips64-softmmu.fa.p/hw_mips_cps.c.o
>> Compiling C object libqemu-mipsel-softmmu.fa.p/hw_mips_cps.c.o
>> Compiling C object libqemu-mips-softmmu.fa.p/hw_mips_cps.c.o
>> Linking target qemu-system-mips
>> Linking target qemu-system-mips64el
>> Linking target qemu-system-mips64
>> Linking target qemu-system-mipsel
>> 10:26:26 [alex.bennee@hackbox2:~/l/q/b/bisect] (a2c93f06…)|BISECTING|✔ + ./tests/venv/bin/avocado run tests/acceptance/machine_mips_malta.py
>> /home/alex.bennee/lsrc/qemu.git/builds/bisect/tests/venv/lib/python3.6/site-packages/avocado/plugins/run.py:214: FutureWarning: The following arguments will be changed to boolean soon: sysinfo, output-check, failfast, keep-tmp and ignore-missing-references.
>> FutureWarning)
>> JOB ID : ccf294ef4e5ebdf19b3a0b53479d574df4ea54ea
>> JOB LOG : /home/alex.bennee/avocado/job-results/job-2020-10-07T10.26-ccf294e/job.log
>> (1/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_1core: PASS (5.82 s)
>> (2/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_7cores: PASS (15.16 s)
>> (3/3) tests/acceptance/machine_mips_malta.py:MaltaMachineFramebuffer.test_mips_malta_i6400_framebuffer_logo_8cores: PASS (15.97 s)
>> RESULTS : PASS 3 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
>> JOB TIME : 40.01 s
>
> Using:
>
> -- >8 --
> diff --git a/hw/misc/mips_cpc.c b/hw/misc/mips_cpc.c
> index 2f7b2c9592..7c11fb3d44 100644
> --- a/hw/misc/mips_cpc.c
> +++ b/hw/misc/mips_cpc.c
> @@ -38,6 +38,7 @@ static void mips_cpu_reset_async_work(CPUState *cs,
> run_on_cpu_data data)
> MIPSCPCState *cpc = (MIPSCPCState *) data.host_ptr;
>
> cpu_reset(cs);
> + cs->halted = 0;
> cpc->vp_running |= 1ULL << cs->cpu_index;
> }
That seems reasonable.
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Do you want to roll that into a proper patch or shall I apply directly
into my testing/next tree?
--
Alex Bennée
next prev parent reply other threads:[~2020-10-07 10:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 5:19 [PULL 00/33] ppc-for-5.2 queue 20200908 David Gibson
2020-09-08 5:19 ` [PULL 01/33] adb: Correct class size on TYPE_ADB_DEVICE David Gibson
2020-09-08 5:19 ` [PULL 02/33] ppc/pnv: Fix TypeInfo of PnvLpcController abstract class David Gibson
2020-09-08 5:19 ` [PULL 03/33] spapr: Remove unnecessary DRC type-checker macros David Gibson
2020-09-08 5:19 ` [PULL 04/33] spapr/xive: Add a 'hv-prio' property to represent the KVM escalation priority David Gibson
2020-09-08 5:19 ` [PULL 05/33] ppc/pnv: Add a HIOMAP erase command David Gibson
2020-09-08 5:19 ` [PULL 06/33] spapr_vscsi: do not allow device hotplug David Gibson
2020-09-08 5:19 ` [PULL 07/33] spapr/xive: Use the xics flag to check for XIVE-only IRQ backends David Gibson
2020-09-08 5:19 ` [PULL 08/33] spapr/xive: Modify kvm_cpu_is_enabled() interface David Gibson
2020-09-08 5:19 ` [PULL 09/33] spapr/xive: Use kvmppc_xive_source_reset() in post_load David Gibson
2020-09-08 5:19 ` [PULL 10/33] spapr/xive: Allocate IPIs independently from the other sources David Gibson
2020-09-08 5:19 ` [PULL 11/33] spapr/xive: Allocate vCPU IPIs from the vCPU contexts David Gibson
2020-09-08 5:19 ` [PULL 12/33] ppc/spapr_nvdimm: use g_autofree in spapr_nvdimm_validate_opts() David Gibson
2020-09-08 5:19 ` [PULL 13/33] spapr, spapr_nvdimm: fold NVDIMM validation in the same place David Gibson
2020-09-08 5:19 ` [PULL 14/33] ppc/spapr_nvdimm: do not enable support with 'nvdimm=off' David Gibson
2020-09-08 5:19 ` [PULL 15/33] target/arm: Move start-powered-off property to generic CPUState David Gibson
2020-09-08 5:19 ` [PULL 16/33] target/arm: Move setting of CPU halted state to generic code David Gibson
2020-09-08 5:19 ` [PULL 17/33] ppc/spapr: Use start-powered-off CPUState property David Gibson
2020-09-08 5:19 ` [PULL 18/33] ppc/e500: " David Gibson
2020-09-08 5:19 ` [PULL 19/33] mips/cps: " David Gibson
2020-10-07 9:28 ` Alex Bennée
2020-10-07 10:36 ` Philippe Mathieu-Daudé
2020-10-07 10:47 ` Alex Bennée [this message]
2020-10-07 11:36 ` Philippe Mathieu-Daudé
2020-09-08 5:19 ` [PULL 20/33] sparc/sun4m: Don't set cs->halted = 0 in main_cpu_reset() David Gibson
2020-09-08 5:19 ` [PULL 21/33] sparc/sun4m: Use start-powered-off CPUState property David Gibson
2020-09-08 5:19 ` [PULL 22/33] target/s390x: " David Gibson
2020-09-08 5:19 ` [PULL 23/33] hw/ppc/ppc4xx_pci: Use ARRAY_SIZE() instead of magic value David Gibson
2020-09-08 5:19 ` [PULL 24/33] hw/ppc/ppc4xx_pci: Replace pointless warning by assert() David Gibson
2020-09-08 5:19 ` [PULL 25/33] ppc: introducing spapr_numa.c NUMA code helper David Gibson
2020-09-08 5:19 ` [PULL 26/33] ppc/spapr_nvdimm: turn spapr_dt_nvdimm() static David Gibson
2020-09-08 5:19 ` [PULL 27/33] spapr: introduce SpaprMachineState::numa_assoc_array David Gibson
2020-09-08 5:19 ` [PULL 28/33] spapr, spapr_numa: handle vcpu ibm,associativity David Gibson
2020-09-08 5:19 ` [PULL 29/33] spapr, spapr_numa: move lookup-arrays handling to spapr_numa.c David Gibson
2020-09-08 5:19 ` [PULL 30/33] spapr_numa: move NVLink2 associativity " David Gibson
2020-09-08 5:19 ` [PULL 31/33] spapr: move h_home_node_associativity " David Gibson
2020-09-08 5:19 ` [PULL 32/33] spapr_numa: create a vcpu associativity helper David Gibson
2020-09-08 5:19 ` [PULL 33/33] spapr_numa: use spapr_numa_get_vcpu_assoc() in home_node hcall David Gibson
2020-09-08 16:23 ` [PULL 00/33] ppc-for-5.2 queue 20200908 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eema1fem.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=bauerman@linux.ibm.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=groug@kaod.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).