From: Markus Armbruster <armbru@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
qemu-block@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Max Reitz" <mreitz@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old()
Date: Thu, 03 Sep 2020 10:54:15 +0200 [thread overview]
Message-ID: <87eenjs0js.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200902170913.1785194-4-berrange@redhat.com> ("Daniel P. Berrangé"'s message of "Wed, 2 Sep 2020 18:09:08 +0100")
Daniel P. Berrangé <berrange@redhat.com> writes:
> We want to introduce a new version of qemu_open() that uses an Error
> object for reporting problems and make this it the preferred interface.
> Rename the existing method to release the namespace for the new impl.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2020-09-03 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 17:09 [PATCH v5 0/8] block: improve error reporting for unsupported O_DIRECT Daniel P. Berrangé
2020-09-02 17:09 ` [PATCH v5 1/8] monitor: simplify functions for getting a dup'd fdset entry Daniel P. Berrangé
2020-09-03 8:52 ` Markus Armbruster
2020-09-03 10:48 ` Daniel P. Berrangé
2020-09-02 17:09 ` [PATCH v5 2/8] util: split off a helper for dealing with O_CLOEXEC flag Daniel P. Berrangé
2020-09-03 8:53 ` Markus Armbruster
2020-09-02 17:09 ` [PATCH v5 3/8] util: rename qemu_open() to qemu_open_old() Daniel P. Berrangé
2020-09-03 8:54 ` Markus Armbruster [this message]
2020-09-02 17:09 ` [PATCH v5 4/8] util: refactor qemu_open_old to split off variadic args handling Daniel P. Berrangé
2020-09-03 9:00 ` Markus Armbruster
2020-09-02 17:09 ` [PATCH v5 5/8] util: add Error object for qemu_open_internal error reporting Daniel P. Berrangé
2020-09-03 9:03 ` Markus Armbruster
2020-09-03 10:54 ` Daniel P. Berrangé
2020-09-02 17:09 ` [PATCH v5 6/8] util: introduce qemu_open and qemu_create with " Daniel P. Berrangé
2020-09-02 17:09 ` [PATCH v5 7/8] util: give a specific error message when O_DIRECT doesn't work Daniel P. Berrangé
2020-09-02 17:09 ` [PATCH v5 8/8] block/file: switch to use qemu_open/qemu_create for improved errors Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eenjs0js.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=f4bug@amsat.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).