From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457BCC2BA16 for ; Tue, 7 Apr 2020 07:11:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0611920678 for ; Tue, 7 Apr 2020 07:11:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YZoMtfYx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0611920678 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLiO8-0002QY-6c for qemu-devel@archiver.kernel.org; Tue, 07 Apr 2020 03:11:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39858) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jLiNY-0001xx-TP for qemu-devel@nongnu.org; Tue, 07 Apr 2020 03:10:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jLiNX-0004rD-ET for qemu-devel@nongnu.org; Tue, 07 Apr 2020 03:10:36 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:23450 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jLiNX-0004qq-AQ for qemu-devel@nongnu.org; Tue, 07 Apr 2020 03:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586243434; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FQ9S4LMw9YVlAY6vBKu8phdzOBWc8NyfHJrlHIzm2f4=; b=YZoMtfYxtodh9yapRXx/64hfR3/40VYNWKRsfQo4JfjYpWWApS7im3Xs1BmTfRk8z5eGRJ m2F34dN3wwsKkqgqhGB+5S3gHHzxviesGB+yPM74eafa51RMqlqAGiHsioRcS1f3G8heEc 6kQbG7FVG9RlBNKo8LCVnrYISIK53WQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-r6af-ut6MlybJu_mMoErBA-1; Tue, 07 Apr 2020 03:10:31 -0400 X-MC-Unique: r6af-ut6MlybJu_mMoErBA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7F3578024D3; Tue, 7 Apr 2020 07:10:30 +0000 (UTC) Received: from redhat.com (ovpn-112-165.ams2.redhat.com [10.36.112.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41DD55D9C5; Tue, 7 Apr 2020 07:10:30 +0000 (UTC) From: Juan Quintela To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH-for-5.1 v2 51/54] migration/colo: Add missing error-propagation code In-Reply-To: <20200406174743.16956-52-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Mon, 6 Apr 2020 19:47:40 +0200") References: <20200406174743.16956-1-f4bug@amsat.org> <20200406174743.16956-52-f4bug@amsat.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Date: Tue, 07 Apr 2020 09:10:28 +0200 Message-ID: <87eeszu5y3.fsf@secure.mitica> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: quintela@redhat.com Cc: Peter Maydell , Vladimir Sementsov-Ogievskiy , Hailiang Zhang , Markus Armbruster , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Philippe Mathieu-Daud=C3=A9 wrote: > Running the coccinelle script produced: > > $ spatch \ > --macro-file scripts/cocci-macro-file.h --include-headers \ > --sp-file scripts/coccinelle/find-missing-error_propagate.cocci \ > --keep-comments --smpl-spacing --dir . > HANDLING: ./migration/colo.c > [[manual check required: error_propagate() might be missing in migrate_= set_block_enabled() ./migration/colo.c:439:4]] > > Add the missing error_propagate() after review. > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Juan Quintela Once there, all other uses of local_error on that file looks correct, and rest of calls to migrate_set_block_enabled() in the rest of qemu looks right. Thanks, Juan.