From: "Keith Packard" <keithp@keithp.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] Semihost SYS_READC implementation
Date: Wed, 23 Oct 2019 12:15:46 -0700 [thread overview]
Message-ID: <87eez31del.fsf@keithp.com> (raw)
In-Reply-To: <5e8913f8-558d-6a2e-c7d0-787ec533e4a9@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
Paolo Bonzini <pbonzini@redhat.com> writes:
> Please take a look at include/qemu/fifo8.h instead of rolling your own
> ring buffer. Note that it is not thread-safe so you'll have to keep
> that part.
Sorry for not looking around sooner, and thanks for the pointer.
I've also cleaned up the other issues.
> Kudos for the unlock/lock_iothread; I am not really familiar with the
> semihosting code and I would have naively assumed that it runs without
> that lock taken.
I discovered by testing that the semihosting functions were entered with
the lock taken :-)
I'll post an updated version of this patch to the list shortly. Thanks
again for your review; I really appreciate the time you've taken to look
at my patch.
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-10-23 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 3:13 [PATCH] Semihost SYS_READC implementation Keith Packard
2019-10-22 8:34 ` Paolo Bonzini
2019-10-22 18:12 ` Keith Packard
2019-10-23 15:51 ` Paolo Bonzini
2019-10-23 19:15 ` Keith Packard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eez31del.fsf@keithp.com \
--to=keithp@keithp.com \
--cc=alex.bennee@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).