From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12E0EC32751 for ; Wed, 7 Aug 2019 15:48:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D342E22293 for ; Wed, 7 Aug 2019 15:48:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e6ZVVAyp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D342E22293 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvOAw-0006iM-4o for qemu-devel@archiver.kernel.org; Wed, 07 Aug 2019 11:48:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58641) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hvO9y-0005E6-NI for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hvO9w-0007c5-PG for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:47:30 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:33810) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hvO9w-0007R9-Hu for qemu-devel@nongnu.org; Wed, 07 Aug 2019 11:47:28 -0400 Received: by mail-wr1-x444.google.com with SMTP id 31so91914115wrm.1 for ; Wed, 07 Aug 2019 08:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:subject:in-reply-to:date:message-id :mime-version:content-transfer-encoding; bh=qzNW4mKc0GDdxTJPmH5HsqCzqdyuVLqpsYmJfLclQw0=; b=e6ZVVAypjSZuOpcpYj3VTW8YF2kqQB/Xzo4KAlJ0zu76TTSg6YvsIoRSny2r92rqKz I5gzCdfAr1Wmkxpw6bLgu1DRxgVQ2M4BQz6ushPdSpMuR4QN4cWfRgKKYJ2Yu8XVahHK vEDQwFWJpJhVOI0UoM97KhNX6oCpoqAQAj3A3xSLcyX8c6C0VOXO3L/7lTvcDQeJt91T YSnPeNtCLkYolCYVaAChqbllvvCy4rwdIqnFr2c8/8JyrBm+y2XI5mGH1Se8peaLQBo7 T3vl/hD4AvlU3ZEfjkKcoevDoaDcRy0sXq9k+YSqV660vs7tP48TN2bGUtbhgaU2JhvH jNCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=qzNW4mKc0GDdxTJPmH5HsqCzqdyuVLqpsYmJfLclQw0=; b=gaMkBuYpIrIrPI6GGlUUzJur4ofamIR+2pmeVXvCxywHcuSYGYbGAcfGLjlC7JOC29 vKk//yLbwUA3W3R2uYNjmk5XUzXi4zU1wpJgV2Vx4oJC5XuTlj9gibkhYbjFuoLhO5hg k8BTcT2/waQRB8hzdvSXtMOydIX1GptK8rhKyxkhjjQbjoin11UFS+iXl9woMEsPYyfF zsTjlOxNmHb3t2si9eFpeC1VNOWlYDxvOmdN+UYFi6D7VYvZWY3V7sr8wJpf7mg6NEyV lNBu84o2XMwHwB4TNpRPsEx1d0mxyi1h65Op1tz/n+XUHziI7ZQjB1NPAG5eyN3AdJpq nO0Q== X-Gm-Message-State: APjAAAXGIE+azYYl2rVzU+TTndPSQw+mgHneDxgZ8ki9v2NIRnb4zfmN FUYuLHqvTNNjKTnr/ntbArLKpxB0Vq0= X-Google-Smtp-Source: APXvYqzomE2ZJ1NOgtEqoYugWlLi2bFKDv6M1ccY9RPH2yJyXATkeAz9+lOKs1nRas1MNVjQCEFoIQ== X-Received: by 2002:a5d:670d:: with SMTP id o13mr2686909wru.289.1565192833929; Wed, 07 Aug 2019 08:47:13 -0700 (PDT) Received: from zen.linaroharston ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id p13sm17194997wrw.90.2019.08.07.08.47.13 for (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 07 Aug 2019 08:47:13 -0700 (PDT) Received: from zen (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 0909C1FF87 for ; Wed, 7 Aug 2019 16:47:13 +0100 (BST) References: <20190806151435.10740-1-armbru@redhat.com> <20190806151435.10740-27-armbru@redhat.com> User-agent: mu4e 1.3.4; emacs 27.0.50 From: Alex =?utf-8?Q?Benn=C3=A9e?= To: qemu-devel@nongnu.org In-reply-to: <20190806151435.10740-27-armbru@redhat.com> Date: Wed, 07 Aug 2019 16:47:12 +0100 Message-ID: <87ef1xhta7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: Re: [Qemu-devel] [PATCH v2 26/29] Clean up inclusion of sysemu/sysemu.h X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Markus Armbruster writes: > In my "build everything" tree, changing sysemu/sysemu.h triggers a > recompile of some 5400 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). > > 119 of 380 #include directives are actually superfluous. Delete them. > Downgrade two more to qapi/qapi-types-run-state.h, and move one from > char/serial.h to char/serial.c. > > This doesn't reduce actual use much, as it's still included into > widely included headers. The next commit will tackle that. > > Signed-off-by: Markus Armbruster > --- > hw/semihosting/config.c | 1 + > stubs/semihost.c | 1 + > diff --git a/hw/semihosting/config.c b/hw/semihosting/config.c > index 2a8e7e1045..9807f10cb0 100644 > --- a/hw/semihosting/config.c > +++ b/hw/semihosting/config.c > @@ -24,6 +24,7 @@ > #include "qemu/error-report.h" > #include "hw/semihosting/semihost.h" > #include "chardev/char.h" > +#include "sysemu/sysemu.h" > > QemuOptsList qemu_semihosting_config_opts =3D { > .name =3D "semihosting-config", > diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c > index b8332150f1..9f3cff5fb6 100644 > > diff --git a/stubs/semihost.c b/stubs/semihost.c > index 4d5b3c0653..f90589259c 100644 > --- a/stubs/semihost.c > +++ b/stubs/semihost.c > @@ -12,6 +12,7 @@ > #include "qemu/option.h" > #include "qemu/error-report.h" > #include "hw/semihosting/semihost.h" > +#include "sysemu/sysemu.h" These additions seem out of place. If I comment them out I can still build fine - I think the only place that needs them is vl.c so it has a typedef for the semihosting configure options. Arguably the extern declaration could be moved into semihostings own headers to avoid polluting sysemu.h more than it needs to? -- Alex Benn=C3=A9e