From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45978) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fezUC-0004QI-47 for qemu-devel@nongnu.org; Mon, 16 Jul 2018 05:08:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fezU8-0004N7-3P for qemu-devel@nongnu.org; Mon, 16 Jul 2018 05:08:04 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:43517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fezU7-0004MQ-SO for qemu-devel@nongnu.org; Mon, 16 Jul 2018 05:08:00 -0400 Received: by mail-wr1-x441.google.com with SMTP id b15-v6so31093232wrv.10 for ; Mon, 16 Jul 2018 02:07:59 -0700 (PDT) References: <20180713121741.19262-1-alex.bennee@linaro.org> <20180713121741.19262-12-alex.bennee@linaro.org> <27bc62f7-919b-7d81-55b0-15cf4f9517e4@amsat.org> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <27bc62f7-919b-7d81-55b0-15cf4f9517e4@amsat.org> Date: Mon, 16 Jul 2018 10:07:57 +0100 Message-ID: <87efg35z0y.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 for 3.0 11/16] docker: add expansion for docker-test-FOO to Makefile.include List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: berrange@redhat.com, richard.henderson@linaro.org, balrogg@gmail.com, cota@braap.org, famz@redhat.com, aurelien@aurel32.net, agraf@suse.de, qemu-devel@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Hi Alex, > > On 07/13/2018 09:17 AM, Alex Benn=C3=A9e wrote: >> This allows us to run a particular test on all docker images. For >> example: >> >> make docker-test-unit >> >> Will run the unit tests on every supported image. At the same time >> rename docker-test to docker-all-tests to be clearer. >> >> Signed-off-by: Alex Benn=C3=A9e >> >> --- >> v2 >> - docker-test -> docker-all-tests >> --- >> tests/docker/Makefile.include | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.inclu= de >> index fe63aacf69..e32c35be0d 100644 >> --- a/tests/docker/Makefile.include >> +++ b/tests/docker/Makefile.include >> @@ -151,7 +151,8 @@ $(foreach i,$(filter-out $(DOCKER_PARTIAL_IMAGES),$(= DOCKER_IMAGES) $(DOCKER_DEPR >> $(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) \ >> ) \ >> $(foreach t,$(DOCKER_TESTS), \ >> - $(eval docker-test: docker-$t@$i) \ >> + $(eval docker-all-tests: docker-$t@$i) \ >> + $(eval docker-$t: docker-$t@$i) \ > > Is this supposed to work this way? > > $ make docker-test-quick@debian-alpha-cross > make: *** No rule to make target > 'docker-test-quick@debian-alpha-cross'. No make docker-test-quick will make the test-quick on all images. Your example fails because debian-alpha-cross is a PARTIAL image, good for building test cases but not QEMU so it's not expanded in the above bit: $(eval docker-$t@$i: docker-image-$i docker-run-$t@$i) > Stop. > >> ) \ >> ) >> >> @@ -161,7 +162,8 @@ docker: >> @echo 'Available targets:' >> @echo >> @echo ' docker: Print this help.' >> - @echo ' docker-test: Run all image/test combinations.' >> + @echo ' docker-all-tests: Run all image/test combinations.' >> + @echo ' docker-TEST: Run TEST on all image combinations.' >> @echo ' docker-clean: Kill and remove residual docker testin= g containers.' >> @echo ' docker-TEST@IMAGE: Run "TEST" in container "IMAGE".' >> @echo ' Note: "TEST" is one of the listed test= name,' >> -- Alex Benn=C3=A9e