qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Bernat <vincent@bernat.im>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <rth@twiddle.net>,
	qemu-devel@nongnu.org, Jiri Denemark <jdenemar@redhat.com>,
	Kashyap Chamarthy <kchamart@redhat.com>
Subject: Re: [Qemu-devel] [PATCH x86-next v2] target-i386: add PCID flag to Westmere, Sandy Bridge and Ivy Bridge
Date: Tue, 16 Jan 2018 13:55:22 +0100	[thread overview]
Message-ID: <87efmqx8sl.fsf@luffy.cx> (raw)
In-Reply-To: <20180116124111.GC627@localhost.localdomain> (Eduardo Habkost's message of "Tue, 16 Jan 2018 10:41:11 -0200")

 ❦ 16 janvier 2018 10:41 -0200, Eduardo Habkost <ehabkost@redhat.com> :

>> > Adding Westmere-PCID would require adding a Westmere-PCID-IBRS
>> > CPU model too, so this is starting to look a bit ridiculous.
>> > Sane VM management systems would know how to use
>> > "-cpu Westmere,+pcid" without requiring new CPU model entries in
>> > QEMU.  What's missing in existing management stacks to allow that
>> > to happen?
>> 
>> That's what I actually do. So, I am fine with the solution of doing
>> nothing. However, it would be nice for unaware people to get the speedup
>> of pcid without knowing about it. Maybe we can just forget about
>> Westmere and still apply it to Sandy Bridge and Ivy Bridge.
>
> If management stacks today don't let the user choose
> "Westmere,+pcid", we probably have no other choice than adding a
> Westmere-PCID CPU model.  But our management stacks need to be
> fixed so we won't need similar hacks in the future.

With libvirt:

  <cpu mode='custom' match='exact'>
    <model>Westmere</model>
    <feature policy='require' name='pcid'/>
  </cpu>

We are using CloudStack on top of that and it's also an available
option. However, looking at OpenStack, it doesn't seem possible:
 https://github.com/openstack/nova/blob/6b248518da794a4c82665c22abf7bee5aa527a47/nova/conf/libvirt.py#L506
-- 
A banker is a fellow who lends you his umbrella when the sun is shining
and wants it back the minute it begins to rain.
		-- Mark Twain

  reply	other threads:[~2018-01-16 12:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09  7:01 [Qemu-devel] [PATCH x86-next v2] target-i386: add PCID flag to Westmere, Sandy Bridge and Ivy Bridge Vincent Bernat
2018-01-12 18:47 ` Eduardo Habkost
2018-01-13  7:22   ` Vincent Bernat
2018-01-16 12:41     ` Eduardo Habkost
2018-01-16 12:55       ` Vincent Bernat [this message]
2018-01-16 15:33         ` Kashyap Chamarthy
2018-01-16 17:08           ` Eduardo Habkost
2018-01-16 17:43             ` Daniel P. Berrange
2018-01-16 22:45               ` Kashyap Chamarthy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87efmqx8sl.fsf@luffy.cx \
    --to=vincent@bernat.im \
    --cc=ehabkost@redhat.com \
    --cc=jdenemar@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).