From: Markus Armbruster <armbru@redhat.com>
To: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
Cc: qemu-devel@nongnu.org, jsnow@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] Python3 Support for qmp.py
Date: Fri, 07 Jul 2017 15:15:50 +0200 [thread overview]
Message-ID: <87eftswfp5.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1499368127-19855-1-git-send-email-chugh.ishani@research.iiit.ac.in> (Ishani Chugh's message of "Fri, 7 Jul 2017 00:38:47 +0530")
Ishani Chugh <chugh.ishani@research.iiit.ac.in> writes:
> This patch intends to make qmp.py compatible with both python2 and python3.
>
> * Python 3 does not have dict.has_key(key), use key in dict instead
> * Avoid line-based I/O since Python 2/3 have different character
> encoding behavior. Explicitly encode/decode JSON UTF-8.
> * Replace print by print function.
>
> Signed-off-by: Ishani Chugh <chugh.ishani@research.iiit.ac.in>
$ scripts/get_maintainer.pl -f $your_patch
Markus Armbruster <armbru@redhat.com> (supporter:QMP)
qemu-devel@nongnu.org (open list:All patches CC here)
Just sayin' :)
prev parent reply other threads:[~2017-07-07 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 19:08 [Qemu-devel] [PATCH v2] Python3 Support for qmp.py Ishani Chugh
2017-07-07 10:37 ` Stefan Hajnoczi
2017-07-07 11:01 ` Daniel P. Berrange
2017-07-13 17:37 ` Ishani
2017-07-07 13:15 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eftswfp5.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=chugh.ishani@research.iiit.ac.in \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).