qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 08/10] docker: Add "images" subcommand to docker.py
Date: Tue, 19 Jul 2016 15:00:14 +0100	[thread overview]
Message-ID: <87eg6pn2xd.fsf@linaro.org> (raw)
In-Reply-To: <1468934445-32183-9-git-send-email-famz@redhat.com>


Fam Zheng <famz@redhat.com> writes:

> This is a wrapper for the 'docker images' command.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/docker.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 40bda9d..222a105 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -179,6 +179,9 @@ class Docker(object):
>              self._instances.remove(label)
>          return ret
>
> +    def command(self, cmd, argv, quiet):
> +        return self._do([cmd] + argv, quiet=quiet)
> +
>  class SubCommand(object):
>      """A SubCommand template base class"""
>      name = None # Subcommand name
> @@ -309,6 +312,12 @@ class CleanCommand(SubCommand):
>          Docker().clean()
>          return 0
>
> +class ImagesCommand(SubCommand):
> +    """Run "docker images" command"""
> +    name = "images"
> +    def run(self, args, argv):
> +        return Docker().command("images", argv, args.quiet)
> +
>  def main():
>      parser = argparse.ArgumentParser(description="A Docker helper",
>              usage="%s <subcommand> ..." % os.path.basename(sys.argv[0]))


--
Alex Bennée

  reply	other threads:[~2016-07-19 14:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 13:20 [Qemu-devel] [PATCH v7 00/10] docker: Support building qemu-user powered docker test images Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 01/10] tests/docker/docker.py: docker_dir outside build Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 02/10] tests/docker/docker.py: support --include-executable Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 03/10] tests/docker/docker.py: check and run .pre script Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 04/10] tests/docker/dockerfiles: new debian-bootstrap.docker Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 05/10] tests/docker/docker.py: add update operation Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 06/10] docker: More sensible run script Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 07/10] docker: Fix exit code if $CMD failed Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 08/10] docker: Add "images" subcommand to docker.py Fam Zheng
2016-07-19 14:00   ` Alex Bennée [this message]
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 09/10] docker: Don't start a container that doesn't exist Fam Zheng
2016-07-19 13:20 ` [Qemu-devel] [PATCH v7 10/10] docker: pass EXECUTABLE to build script Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eg6pn2xd.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).