From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPVZN-0008JQ-50
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 10:00:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPVZI-0003yh-8e
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 10:00:21 -0400
Received: from mail-wm0-x233.google.com ([2a00:1450:400c:c09::233]:36517)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1bPVZG-0003yV-V7
	for qemu-devel@nongnu.org; Tue, 19 Jul 2016 10:00:16 -0400
Received: by mail-wm0-x233.google.com with SMTP id q128so20437903wma.1
	for <qemu-devel@nongnu.org>; Tue, 19 Jul 2016 07:00:14 -0700 (PDT)
References: <1468934445-32183-1-git-send-email-famz@redhat.com>
	<1468934445-32183-9-git-send-email-famz@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1468934445-32183-9-git-send-email-famz@redhat.com>
Date: Tue, 19 Jul 2016 15:00:14 +0100
Message-ID: <87eg6pn2xd.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v7 08/10] docker: Add "images" subcommand
 to docker.py
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org


Fam Zheng <famz@redhat.com> writes:

> This is a wrapper for the 'docker images' command.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> ---
>  tests/docker/docker.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index 40bda9d..222a105 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -179,6 +179,9 @@ class Docker(object):
>              self._instances.remove(label)
>          return ret
>
> +    def command(self, cmd, argv, quiet):
> +        return self._do([cmd] + argv, quiet=quiet)
> +
>  class SubCommand(object):
>      """A SubCommand template base class"""
>      name = None # Subcommand name
> @@ -309,6 +312,12 @@ class CleanCommand(SubCommand):
>          Docker().clean()
>          return 0
>
> +class ImagesCommand(SubCommand):
> +    """Run "docker images" command"""
> +    name = "images"
> +    def run(self, args, argv):
> +        return Docker().command("images", argv, args.quiet)
> +
>  def main():
>      parser = argparse.ArgumentParser(description="A Docker helper",
>              usage="%s <subcommand> ..." % os.path.basename(sys.argv[0]))


--
Alex Bennée