From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5y7F-00013X-4m for qemu-devel@nongnu.org; Thu, 26 May 2016 12:26:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5y7A-0000ZL-Tm for qemu-devel@nongnu.org; Thu, 26 May 2016 12:26:32 -0400 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:36822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5y7A-0000ZE-Bm for qemu-devel@nongnu.org; Thu, 26 May 2016 12:26:28 -0400 Received: by mail-wm0-x22f.google.com with SMTP id n129so235243165wmn.1 for ; Thu, 26 May 2016 09:26:28 -0700 (PDT) References: <1463986466-764-1-git-send-email-famz@redhat.com> From: Alex =?utf-8?Q?Benn=C3=A9e?= In-reply-to: <1463986466-764-1-git-send-email-famz@redhat.com> Date: Thu, 26 May 2016 17:26:59 +0100 Message-ID: <87eg8odbu4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v5 00/14] tests: Introducing docker tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Peter Maydell Fam Zheng writes: > v5: Use docker run's selinux option "z" on passed volume, drop --privileged. > Allow overriding "TARGET_LIST" in clang-test. > Add Alex's r-b lines in patches 1, 3, 9, 11 and 13. > > This series adds a new "docker" make target family to run tests in created > docker containers. > > To begin with, this can be a place to store standard env/command combinations to > build and test QEMU. > > Secondly, CI usually provides "docker" capability, where we specify > standard/repeatable test environments, and run tests in them. However, what > tests to cover is better maintained in-tree, in order to keep in sync with the > code development. > > Lastly, this makes it very simple for developers to replicate such tests > themselves. Aside from the minor quibble on docker.py (which I can fix up on later patches if you want) I think this series it ready to be merged. Are you going to submit a PULL REQ to Peter? > > > Fam Zheng (14): > tests: Add utilities for docker testing > rules.mak: Add "COMMA" constant > Makefile: Rules for docker testing > docker: Add images > docker: Add test runner > docker: Add common.rc > docker: Add quick test > docker: Add full test > docker: Add clang test > docker: Add mingw test > docker: Add travis tool > docs: Add text for tests/docker in build-system.txt > docker: Add EXTRA_CONFIGURE_OPTS > MAINTAINERS: Add tests/docker > > MAINTAINERS | 7 ++ > Makefile | 4 +- > docs/build-system.txt | 5 + > rules.mak | 2 + > tests/docker/Makefile.include | 124 +++++++++++++++++++++ > tests/docker/common.rc | 32 ++++++ > tests/docker/docker.py | 191 ++++++++++++++++++++++++++++++++ > tests/docker/dockerfiles/centos6.docker | 6 + > tests/docker/dockerfiles/fedora.docker | 7 ++ > tests/docker/dockerfiles/ubuntu.docker | 11 ++ > tests/docker/run | 58 ++++++++++ > tests/docker/test-clang | 26 +++++ > tests/docker/test-full | 17 +++ > tests/docker/test-mingw | 34 ++++++ > tests/docker/test-quick | 19 ++++ > tests/docker/travis | 21 ++++ > tests/docker/travis.py | 48 ++++++++ > 17 files changed, 611 insertions(+), 1 deletion(-) > create mode 100644 tests/docker/Makefile.include > create mode 100755 tests/docker/common.rc > create mode 100755 tests/docker/docker.py > create mode 100644 tests/docker/dockerfiles/centos6.docker > create mode 100644 tests/docker/dockerfiles/fedora.docker > create mode 100644 tests/docker/dockerfiles/ubuntu.docker > create mode 100755 tests/docker/run > create mode 100755 tests/docker/test-clang > create mode 100755 tests/docker/test-full > create mode 100755 tests/docker/test-mingw > create mode 100755 tests/docker/test-quick > create mode 100755 tests/docker/travis > create mode 100755 tests/docker/travis.py -- Alex Bennée