From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41802)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZYyhB-0004H2-BB
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:51:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZYyh8-0002Bi-M5
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:51:01 -0400
Received: from mail-wi0-f181.google.com ([209.85.212.181]:36205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1ZYyh8-0002Bc-HB
	for qemu-devel@nongnu.org; Mon, 07 Sep 2015 11:50:58 -0400
Received: by wicgb1 with SMTP id gb1so50149816wic.1
	for <qemu-devel@nongnu.org>; Mon, 07 Sep 2015 08:50:58 -0700 (PDT)
References: <1440375847-17603-1-git-send-email-cota@braap.org>
	<1440375847-17603-7-git-send-email-cota@braap.org>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1440375847-17603-7-git-send-email-cota@braap.org>
Date: Mon, 07 Sep 2015 16:50:56 +0100
Message-ID: <87egia9qjj.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RFC 06/38] seqlock: add missing 'inline' to
	seqlock_read_retry
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Emilio G. Cota" <cota@braap.org>
Cc: mttcg@listserver.greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, pbonzini@redhat.com, Frederic Konrad <fred.konrad@greensocs.com>


Emilio G. Cota <cota@braap.org> writes:

> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
>  include/qemu/seqlock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qemu/seqlock.h b/include/qemu/seqlock.h
> index 3ff118a..f1256f5 100644
> --- a/include/qemu/seqlock.h
> +++ b/include/qemu/seqlock.h
> @@ -62,7 +62,7 @@ static inline unsigned seqlock_read_begin(QemuSeqLock *sl)
>      return ret;
>  }
>  
> -static int seqlock_read_retry(const QemuSeqLock *sl, unsigned start)
> +static inline int seqlock_read_retry(const QemuSeqLock *sl, unsigned start)
>  {
>      /* Read other fields before reading final sequence.  */
>      smp_rmb();

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

You could send this to qemu-trivial now if you want.

-- 
Alex Bennée