From: Juan Quintela <quintela@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, laine@redhat.com,
lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/7] runstate: Add runstate store
Date: Mon, 20 Oct 2014 12:52:34 +0200 [thread overview]
Message-ID: <87egu357yl.fsf@elfo.elfo> (raw)
In-Reply-To: <20141020102408.GF2517@work-vm> (David Alan Gilbert's message of "Mon, 20 Oct 2014 11:24:09 +0100")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * Juan Quintela (quintela@redhat.com) wrote:
>> This allows us to store the current state to send it through migration.
>
> Why store the runstate as a string? The later code then ends up doing
> string compares and things - why not just use the enum value?
How do you know that it has the same values both sides? As far as I can
see, all interaction with the outside is done with strings (i.e. QMP).
But it is easier for me if I can sent the numeric value.
Libvirt folks?
Luiz?
What should I do?
Later, Juan.
>
> Dave
>
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>> ---
>> include/sysemu/sysemu.h | 1 +
>> vl.c | 10 ++++++++++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
>> index d8539fd..ae217da 100644
>> --- a/include/sysemu/sysemu.h
>> +++ b/include/sysemu/sysemu.h
>> @@ -28,6 +28,7 @@ bool runstate_check(RunState state);
>> void runstate_set(RunState new_state);
>> int runstate_is_running(void);
>> bool runstate_needs_reset(void);
>> +int runstate_store(char *str, int size);
>> typedef struct vm_change_state_entry VMChangeStateEntry;
>> typedef void VMChangeStateHandler(void *opaque, int running, RunState state);
>>
>> diff --git a/vl.c b/vl.c
>> index 964d634..ce8e28b 100644
>> --- a/vl.c
>> +++ b/vl.c
>> @@ -677,6 +677,16 @@ bool runstate_check(RunState state)
>> return current_run_state == state;
>> }
>>
>> +int runstate_store(char *str, int size)
>> +{
>> + const char *state = RunState_lookup[current_run_state];
>> +
>> + if (strlen(state)+1 > size)
>> + return -1;
>> + strncpy(str, state, strlen(state)+1);
>> + return 0;
>> +}
>> +
>> static void runstate_init(void)
>> {
>> const RunStateTransition *p;
>> --
>> 2.1.0
>>
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2014-10-20 10:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 7:55 [Qemu-devel] [RFC 0/7] Optional toplevel sections Juan Quintela
2014-10-15 7:55 ` [Qemu-devel] [PATCH 1/7] migration: Create optional sections Juan Quintela
2014-10-15 7:55 ` [Qemu-devel] [PATCH 2/7] runstate: Add runstate store Juan Quintela
2014-10-20 10:24 ` Dr. David Alan Gilbert
2014-10-20 10:52 ` Juan Quintela [this message]
2014-10-20 15:18 ` Eric Blake
2014-10-22 11:18 ` Dr. David Alan Gilbert
2014-10-22 11:40 ` Markus Armbruster
2014-10-22 15:52 ` Eric Blake
2014-10-15 7:55 ` [Qemu-devel] [PATCH 3/7] runstate: create runstate_index function Juan Quintela
2014-10-15 7:55 ` [Qemu-devel] [PATCH 4/7] runstate: migration allows more transitions now Juan Quintela
2014-10-15 14:42 ` Eric Blake
2014-10-15 15:50 ` Juan Quintela
2014-11-03 12:46 ` Amit Shah
2014-10-15 7:55 ` [Qemu-devel] [PATCH 5/7] migration: create now section to store global state Juan Quintela
2014-10-20 10:52 ` Dr. David Alan Gilbert
2014-10-20 11:11 ` Kevin Wolf
2014-10-15 7:55 ` [Qemu-devel] [PATCH 6/7] global_state: Make section optional Juan Quintela
2014-10-15 7:55 ` [Qemu-devel] [PATCH 7/7] vmstate: Create optional sections Juan Quintela
2014-10-15 14:45 ` Eric Blake
2014-10-15 14:57 ` [Qemu-devel] [RFC 0/7] Optional toplevel sections Eric Blake
2014-10-15 15:59 ` Juan Quintela
2014-10-15 16:37 ` Eric Blake
2014-10-17 13:41 ` Paolo Bonzini
2014-10-20 14:59 ` Dr. David Alan Gilbert
2014-10-20 11:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87egu357yl.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=laine@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).