From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpHYH-0001SW-NH for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpHYG-0001DS-IS for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:53 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:53803) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpHYG-0001DO-EC for qemu-devel@nongnu.org; Wed, 19 Jun 2013 08:31:52 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 08:31:52 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 2AD85C90049 for ; Wed, 19 Jun 2013 08:31:48 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5JCVlDQ106474 for ; Wed, 19 Jun 2013 08:31:48 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5JCY95t003151 for ; Wed, 19 Jun 2013 06:34:09 -0600 From: Anthony Liguori In-Reply-To: <1371627895-27046-2-git-send-email-armbru@redhat.com> References: <1371627895-27046-1-git-send-email-armbru@redhat.com> <1371627895-27046-2-git-send-email-armbru@redhat.com> Date: Wed, 19 Jun 2013 07:31:39 -0500 Message-ID: <87ehby1duc.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/2] libqtest: Plug fd and memory leaks in qtest_quit() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Markus Armbruster writes: > Signed-off-by: Markus Armbruster Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > tests/libqtest.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/libqtest.c b/tests/libqtest.c > index 879ffe9..bb82069 100644 > --- a/tests/libqtest.c > +++ b/tests/libqtest.c > @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s) > waitpid(pid, &status, 0); > } > > + close(s->fd); > + close(s->qmp_fd); > + g_string_free(s->rx, true); > unlink(s->pid_file); > unlink(s->socket_path); > unlink(s->qmp_socket_path); > g_free(s->pid_file); > g_free(s->socket_path); > g_free(s->qmp_socket_path); > + g_free(s); > } > > static void socket_sendf(int fd, const char *fmt, va_list ap) > -- > 1.7.11.7