From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoFPQ-0005fW-F1 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:02:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UoFPL-0000CF-V4 for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:02:28 -0400 Received: from e35.co.us.ibm.com ([32.97.110.153]:34741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UoFPL-0000Ak-Ph for qemu-devel@nongnu.org; Sun, 16 Jun 2013 12:02:23 -0400 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 16 Jun 2013 10:02:19 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id B940E19D8042 for ; Sun, 16 Jun 2013 10:01:55 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5GG23eF128778 for ; Sun, 16 Jun 2013 10:02:03 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5GG22Pv020106 for ; Sun, 16 Jun 2013 10:02:03 -0600 From: Anthony Liguori In-Reply-To: <1371397053-4503-2-git-send-email-lilei@linux.vnet.ibm.com> References: <1371397053-4503-1-git-send-email-lilei@linux.vnet.ibm.com> <1371397053-4503-2-git-send-email-lilei@linux.vnet.ibm.com> Date: Sun, 16 Jun 2013 11:01:59 -0500 Message-ID: <87ehc2hwnc.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 1/7] migration: export MIG_STATE_xxx flags List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lei Li , qemu-devel@nongnu.org Cc: lagarcia@br.ibm.com, quintela@redhat.com Lei Li writes: > Signed-off-by: Lei Li > --- > include/migration/migration.h | 8 ++++++++ > migration.c | 8 -------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/migration/migration.h b/include/migration/migration.h > index e2acec6..8866c3c 100644 > --- a/include/migration/migration.h > +++ b/include/migration/migration.h > @@ -22,6 +22,14 @@ > #include "migration/vmstate.h" > #include "qapi-types.h" > > +enum { > + MIG_STATE_ERROR, > + MIG_STATE_SETUP, > + MIG_STATE_CANCELLED, > + MIG_STATE_ACTIVE, > + MIG_STATE_COMPLETED, > +}; > + If these flags are being exported, it would be nice to provide comments describing what each state corresponded to. Regards, Anthony Liguori > struct MigrationParams { > bool blk; > bool shared; > diff --git a/migration.c b/migration.c > index 058f9e6..0921ace 100644 > --- a/migration.c > +++ b/migration.c > @@ -35,14 +35,6 @@ > do { } while (0) > #endif > > -enum { > - MIG_STATE_ERROR, > - MIG_STATE_SETUP, > - MIG_STATE_CANCELLED, > - MIG_STATE_ACTIVE, > - MIG_STATE_COMPLETED, > -}; > - > #define MAX_THROTTLE (32 << 20) /* Migration speed throttling */ > > /* Amount of time to allocate to each "chunk" of bandwidth-throttled > -- > 1.7.7.6